third_party/WebKit/Source/core/editing/EditingStyle.h - Issue 1929493002: Remove unnecessary uses of GarbageCollectedFinalized<>.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/editing/EditingStyle.h

Issue 1929493002: Remove unnecessary uses of GarbageCollectedFinalized<>. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: add two leftover classes needing same treatment Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/dom/custom/V0CustomElementProcessingStack.h ('k') | third_party/WebKit/Source/core/editing/EditingStyle.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/editing/EditingStyle.h

diff --git a/third_party/WebKit/Source/core/editing/EditingStyle.h b/third_party/WebKit/Source/core/editing/EditingStyle.h

index 6ea11aa330c028e560249fe2a645d315d6fd0855..1b394a4aab4ae18fd6918377883145a539fa8b56 100644

--- a/third_party/WebKit/Source/core/editing/EditingStyle.h

+++ b/third_party/WebKit/Source/core/editing/EditingStyle.h

@@ -57,7 +57,7 @@ class QualifiedName;

class ComputedStyle;

class StylePropertySet;

-class EditingStyle final : public GarbageCollectedFinalized<EditingStyle> {

+class EditingStyle final : public GarbageCollected<EditingStyle> {

public:

enum PropertiesToInclude { AllProperties, OnlyEditingInheritableProperties, EditingPropertiesInEffect };

@@ -90,8 +90,6 @@ public:

return new EditingStyle(propertyID, value);

}

- ~EditingStyle();

MutableStylePropertySet* style() { return m_mutableStyle.get(); }

bool textDirection(WritingDirection&) const;

bool isEmpty() const;