Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(18)

Side by Side Diff: third_party/WebKit/Source/core/inspector/CodeGeneratorInstrumentation.py

Issue 1929493002: Remove unnecessary uses of GarbageCollectedFinalized<>. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: add two leftover classes needing same treatment Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 #!/usr/bin/env python 1 #!/usr/bin/env python
2 # Copyright (c) 2013 Google Inc. All rights reserved. 2 # Copyright (c) 2013 Google Inc. All rights reserved.
3 # 3 #
4 # Redistribution and use in source and binary forms, with or without 4 # Redistribution and use in source and binary forms, with or without
5 # modification, are permitted provided that the following conditions are 5 # modification, are permitted provided that the following conditions are
6 # met: 6 # met:
7 # 7 #
8 # * Redistributions of source code must retain the above copyright 8 # * Redistributions of source code must retain the above copyright
9 # notice, this list of conditions and the following disclaimer. 9 # notice, this list of conditions and the following disclaimer.
10 # * Redistributions in binary form must reproduce the above 10 # * Redistributions in binary form must reproduce the above
(...skipping 79 matching lines...) Expand 10 before | Expand all | Expand 10 after
90 #include "core/CoreExport.h" 90 #include "core/CoreExport.h"
91 #include "platform/heap/Handle.h" 91 #include "platform/heap/Handle.h"
92 #include "wtf/Allocator.h" 92 #include "wtf/Allocator.h"
93 #include "wtf/Noncopyable.h" 93 #include "wtf/Noncopyable.h"
94 #include "wtf/PassRefPtr.h" 94 #include "wtf/PassRefPtr.h"
95 95
96 namespace blink { 96 namespace blink {
97 97
98 ${forward_list} 98 ${forward_list}
99 99
100 class CORE_EXPORT InstrumentingAgents : public GarbageCollectedFinalized<Instrum entingAgents> { 100 class CORE_EXPORT InstrumentingAgents : public GarbageCollected<InstrumentingAge nts> {
101 WTF_MAKE_NONCOPYABLE(InstrumentingAgents); 101 WTF_MAKE_NONCOPYABLE(InstrumentingAgents);
102 public: 102 public:
103 InstrumentingAgents(); 103 InstrumentingAgents();
104 ~InstrumentingAgents() { }
105 DECLARE_TRACE(); 104 DECLARE_TRACE();
106 105
107 ${accessor_list} 106 ${accessor_list}
108 107
109 private: 108 private:
110 ${member_list} 109 ${member_list}
111 }; 110 };
112 111
113 } 112 }
114 113
(...skipping 335 matching lines...) Expand 10 before | Expand all | Expand 10 after
450 if not output_dirpath: 449 if not output_dirpath:
451 raise Exception("Output directory must be specified") 450 raise Exception("Output directory must be specified")
452 except Exception: 451 except Exception:
453 # Work with python 2 and 3 http://docs.python.org/py3k/howto/pyporting.html 452 # Work with python 2 and 3 http://docs.python.org/py3k/howto/pyporting.html
454 exc = sys.exc_info()[1] 453 exc = sys.exc_info()[1]
455 sys.stderr.write("Failed to parse command-line arguments: %s\n\n" % exc) 454 sys.stderr.write("Failed to parse command-line arguments: %s\n\n" % exc)
456 sys.stderr.write("Usage: <script> --output_dir <output_dir> InspectorInstrum entation.idl\n") 455 sys.stderr.write("Usage: <script> --output_dir <output_dir> InspectorInstrum entation.idl\n")
457 exit(1) 456 exit(1)
458 457
459 generate(input_path, output_dirpath) 458 generate(input_path, output_dirpath)
OLDNEW
« no previous file with comments | « third_party/WebKit/Source/core/html/ValidityState.h ('k') | third_party/WebKit/Source/core/inspector/InspectedFrames.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698