third_party/WebKit/Source/core/inspector/CodeGeneratorInstrumentation.py - Issue 1929493002: Remove unnecessary uses of GarbageCollectedFinalized<>.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/inspector/CodeGeneratorInstrumentation.py

Issue 1929493002: Remove unnecessary uses of GarbageCollectedFinalized<>. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: add two leftover classes needing same treatment Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/html/ValidityState.h ('k') | third_party/WebKit/Source/core/inspector/InspectedFrames.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/inspector/CodeGeneratorInstrumentation.py

diff --git a/third_party/WebKit/Source/core/inspector/CodeGeneratorInstrumentation.py b/third_party/WebKit/Source/core/inspector/CodeGeneratorInstrumentation.py

index 6169fc8fd9553fd7302ae02238044f6f10bff4ae..4065ddf2fbf02e544cc292b09367861f2e2b6035 100755

--- a/third_party/WebKit/Source/core/inspector/CodeGeneratorInstrumentation.py

+++ b/third_party/WebKit/Source/core/inspector/CodeGeneratorInstrumentation.py

@@ -97,11 +97,10 @@ namespace blink {

${forward_list}

-class CORE_EXPORT InstrumentingAgents : public GarbageCollectedFinalized<InstrumentingAgents> {

+class CORE_EXPORT InstrumentingAgents : public GarbageCollected<InstrumentingAgents> {

WTF_MAKE_NONCOPYABLE(InstrumentingAgents);

public:

InstrumentingAgents();

- ~InstrumentingAgents() { }

DECLARE_TRACE();

${accessor_list}

« no previous file with comments | « third_party/WebKit/Source/core/html/ValidityState.h ('k') | third_party/WebKit/Source/core/inspector/InspectedFrames.h » ('j') | no next file with comments »