Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(275)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1898793003: Make QuicDispatcher's helper and alarm factory arguments unique_ptrs to make ownership clear. (Closed)

Created:
4 years, 8 months ago by alyssar1
Modified:
4 years, 8 months ago
Reviewers:
Ryan Hamilton
CC:
chromium-reviews, cbentzel+watch_chromium.org, dcheng
Base URL:
https://chromium.googlesource.com/chromium/src.git@119871679
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Make QuicDispatcher's helper and alarm factory arguments unique_ptrs to make ownership clear. Merge internal change: 119753783 R=rch@chromium.org BUG=

Patch Set 1 #

Patch Set 2 : fixing rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1089 lines, -663 lines) Patch
M net/BUILD.gn View 1 chunk +2 lines, -0 lines 0 comments Download
M net/net.gyp View 1 chunk +2 lines, -0 lines 0 comments Download
M net/net.gypi View 4 chunks +5 lines, -0 lines 0 comments Download
M net/quic/bidirectional_stream_quic_impl_unittest.cc View 3 chunks +6 lines, -3 lines 0 comments Download
M net/quic/p2p/quic_p2p_session_test.cc View 4 chunks +8 lines, -5 lines 0 comments Download
A net/quic/quic_alarm_factory.h View 1 chunk +39 lines, -0 lines 0 comments Download
A net/quic/quic_chromium_alarm_factory.h View 1 chunk +46 lines, -0 lines 0 comments Download
A net/quic/quic_chromium_alarm_factory.cc View 1 chunk +117 lines, -0 lines 0 comments Download
A net/quic/quic_chromium_alarm_factory_test.cc View 1 chunk +176 lines, -0 lines 0 comments Download
M net/quic/quic_chromium_client_session.cc View 1 chunk +1 line, -0 lines 0 comments Download
M net/quic/quic_chromium_client_session_test.cc View 4 chunks +6 lines, -3 lines 0 comments Download
M net/quic/quic_chromium_client_stream_test.cc View 2 chunks +2 lines, -0 lines 0 comments Download
M net/quic/quic_chromium_connection_helper.h View 2 chunks +2 lines, -9 lines 0 comments Download
M net/quic/quic_chromium_connection_helper.cc View 2 chunks +1 line, -99 lines 0 comments Download
M net/quic/quic_chromium_connection_helper_test.cc View 2 chunks +1 line, -139 lines 0 comments Download
M net/quic/quic_client_promised_info.h View 1 chunk +0 lines, -1 line 0 comments Download
M net/quic/quic_client_promised_info.cc View 2 chunks +5 lines, -5 lines 0 comments Download
M net/quic/quic_client_promised_info_test.cc View 3 chunks +5 lines, -3 lines 0 comments Download
M net/quic/quic_client_push_promise_index_test.cc View 2 chunks +4 lines, -2 lines 0 comments Download
M net/quic/quic_connection.h View 5 chunks +4 lines, -14 lines 0 comments Download
M net/quic/quic_connection.cc View 3 chunks +14 lines, -7 lines 0 comments Download
M net/quic/quic_connection_logger_unittest.cc View 2 chunks +3 lines, -1 line 0 comments Download
M net/quic/quic_connection_test.cc View 11 chunks +53 lines, -36 lines 0 comments Download
M net/quic/quic_crypto_client_stream_test.cc View 6 chunks +17 lines, -12 lines 0 comments Download
M net/quic/quic_crypto_server_stream_test.cc View 5 chunks +16 lines, -11 lines 0 comments Download
M net/quic/quic_crypto_stream_test.cc View 2 chunks +4 lines, -1 line 0 comments Download
A net/quic/quic_epoll_alarm_factory_test.cc View 1 chunk +127 lines, -0 lines 0 comments Download
M net/quic/quic_flow_controller_test.cc View 2 chunks +2 lines, -1 line 0 comments Download
M net/quic/quic_headers_stream_test.cc View 2 chunks +2 lines, -0 lines 0 comments Download
M net/quic/quic_http_stream_test.cc View 4 chunks +11 lines, -5 lines 0 comments Download
M net/quic/quic_session_test.cc View 2 chunks +2 lines, -0 lines 0 comments Download
M net/quic/quic_spdy_stream_test.cc View 2 chunks +3 lines, -1 line 0 comments Download
M net/quic/quic_stream_factory.h View 3 chunks +4 lines, -1 line 0 comments Download
M net/quic/quic_stream_factory.cc View 2 chunks +9 lines, -5 lines 0 comments Download
M net/quic/quic_stream_sequencer_test.cc View 2 chunks +4 lines, -1 line 0 comments Download
M net/quic/reliable_quic_stream_test.cc View 2 chunks +2 lines, -1 line 0 comments Download
M net/quic/test_tools/crypto_test_utils.h View 1 chunk +4 lines, -0 lines 0 comments Download
M net/quic/test_tools/crypto_test_utils.cc View 2 chunks +6 lines, -3 lines 0 comments Download
M net/quic/test_tools/mock_quic_dispatcher.h View 1 chunk +2 lines, -2 lines 0 comments Download
M net/quic/test_tools/mock_quic_dispatcher.cc View 1 chunk +7 lines, -2 lines 0 comments Download
M net/quic/test_tools/quic_connection_peer.h View 1 chunk +2 lines, -0 lines 0 comments Download
M net/quic/test_tools/quic_connection_peer.cc View 1 chunk +6 lines, -0 lines 0 comments Download
M net/quic/test_tools/quic_test_utils.h View 5 chunks +26 lines, -11 lines 0 comments Download
M net/quic/test_tools/quic_test_utils.cc View 7 chunks +23 lines, -9 lines 0 comments Download
M net/tools/quic/end_to_end_test.cc View 3 chunks +6 lines, -1 line 0 comments Download
M net/tools/quic/quic_client.h View 1 chunk +1 line, -0 lines 0 comments Download
M net/tools/quic/quic_client.cc View 2 chunks +2 lines, -1 line 0 comments Download
M net/tools/quic/quic_client_base.h View 3 chunks +6 lines, -0 lines 0 comments Download
M net/tools/quic/quic_client_base.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M net/tools/quic/quic_client_session_test.cc View 2 chunks +5 lines, -3 lines 0 comments Download
M net/tools/quic/quic_dispatcher.h View 3 chunks +7 lines, -5 lines 0 comments Download
M net/tools/quic/quic_dispatcher.cc View 3 chunks +13 lines, -8 lines 0 comments Download
M net/tools/quic/quic_dispatcher_test.cc View 17 chunks +40 lines, -23 lines 0 comments Download
A net/tools/quic/quic_epoll_alarm_factory.h View 1 chunk +36 lines, -0 lines 0 comments Download
A net/tools/quic/quic_epoll_alarm_factory.cc View 1 chunk +76 lines, -0 lines 0 comments Download
M net/tools/quic/quic_epoll_connection_helper.h View 2 chunks +0 lines, -6 lines 0 comments Download
M net/tools/quic/quic_epoll_connection_helper.cc View 2 chunks +2 lines, -68 lines 0 comments Download
M net/tools/quic/quic_epoll_connection_helper_test.cc View 1 chunk +0 lines, -115 lines 0 comments Download
M net/tools/quic/quic_server.h View 1 chunk +1 line, -0 lines 0 comments Download
M net/tools/quic/quic_server.cc View 2 chunks +8 lines, -3 lines 0 comments Download
M net/tools/quic/quic_server_session_base_test.cc View 2 chunks +4 lines, -2 lines 0 comments Download
M net/tools/quic/quic_server_test.cc View 2 chunks +6 lines, -1 line 0 comments Download
M net/tools/quic/quic_simple_client.h View 2 chunks +2 lines, -0 lines 0 comments Download
M net/tools/quic/quic_simple_client.cc View 5 chunks +11 lines, -4 lines 0 comments Download
M net/tools/quic/quic_simple_server.h View 2 chunks +4 lines, -0 lines 0 comments Download
M net/tools/quic/quic_simple_server.cc View 3 chunks +15 lines, -8 lines 0 comments Download
M net/tools/quic/quic_simple_server_session_test.cc View 4 chunks +8 lines, -3 lines 0 comments Download
M net/tools/quic/quic_simple_server_stream_test.cc View 2 chunks +2 lines, -0 lines 0 comments Download
M net/tools/quic/quic_simple_server_test.cc View 1 chunk +4 lines, -1 line 0 comments Download
M net/tools/quic/quic_spdy_client_stream_test.cc View 2 chunks +4 lines, -2 lines 0 comments Download
M net/tools/quic/quic_time_wait_list_manager.h View 1 chunk +4 lines, -2 lines 0 comments Download
M net/tools/quic/quic_time_wait_list_manager.cc View 1 chunk +3 lines, -2 lines 0 comments Download
M net/tools/quic/quic_time_wait_list_manager_test.cc View 4 chunks +5 lines, -1 line 0 comments Download
M net/tools/quic/test_tools/mock_quic_time_wait_list_manager.h View 1 chunk +2 lines, -1 line 0 comments Download
M net/tools/quic/test_tools/mock_quic_time_wait_list_manager.cc View 1 chunk +3 lines, -2 lines 0 comments Download
M net/tools/quic/test_tools/packet_dropping_test_writer.h View 1 chunk +1 line, -0 lines 0 comments Download
M net/tools/quic/test_tools/packet_dropping_test_writer.cc View 1 chunk +3 lines, -2 lines 0 comments Download
M net/tools/quic/test_tools/quic_dispatcher_peer.h View 1 chunk +2 lines, -0 lines 0 comments Download
M net/tools/quic/test_tools/quic_dispatcher_peer.cc View 1 chunk +6 lines, -0 lines 0 comments Download
M net/tools/quic/test_tools/quic_test_server.cc View 5 chunks +14 lines, -6 lines 0 comments Download

Depends on Patchset:

Issue 1899753003 Patch 20001

Messages

Total messages: 2 (0 generated)
alyssar1
4 years, 8 months ago (2016-04-18 19:16:57 UTC) #1
Ryan Hamilton
4 years, 8 months ago (2016-04-18 22:11:38 UTC) #2 
This CL seems to have changes from https://codereview.chromium.org/1899753003/
Is that expected?

Powered by Google App Engine
This is Rietveld 408576698