Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(673)

Unified Diff: net/tools/quic/quic_client_base.h

Issue 1898793003: Make QuicDispatcher's helper and alarm factory arguments unique_ptrs to make ownership clear. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@119871679
Patch Set: fixing rebase Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « net/tools/quic/quic_client.cc ('k') | net/tools/quic/quic_client_base.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/tools/quic/quic_client_base.h
diff --git a/net/tools/quic/quic_client_base.h b/net/tools/quic/quic_client_base.h
index af44bdaca19ffc624c585d606180c35b7259ad6f..0c0da3592c48635f2f8ed1eb9cb888a9f50feec1 100644
--- a/net/tools/quic/quic_client_base.h
+++ b/net/tools/quic/quic_client_base.h
@@ -36,6 +36,7 @@ class QuicClientBase {
const QuicVersionVector& supported_versions,
const QuicConfig& config,
QuicConnectionHelperInterface* helper,
+ QuicAlarmFactory* alarm_factory,
ProofVerifier* proof_verifier);
~QuicClientBase();
@@ -181,6 +182,8 @@ class QuicClientBase {
QuicConnectionHelperInterface* helper() { return helper_.get(); }
+ QuicAlarmFactory* alarm_factory() { return alarm_factory_.get(); }
+
void set_num_sent_client_hellos(int num_sent_client_hellos) {
num_sent_client_hellos_ = num_sent_client_hellos;
}
@@ -201,6 +204,9 @@ class QuicClientBase {
// Helper to be used by created connections. Needs to outlive |session_|.
scoped_ptr<QuicConnectionHelperInterface> helper_;
+ // Alarm factory used for alarm creation. Needs to outlive |session_|.
+ scoped_ptr<QuicAlarmFactory> alarm_factory_;
+
// Writer used to actually send packets to the wire. Needs to outlive
// |session_|.
scoped_ptr<QuicPacketWriter> writer_;
« no previous file with comments | « net/tools/quic/quic_client.cc ('k') | net/tools/quic/quic_client_base.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698