Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(294)

Unified Diff: net/tools/quic/quic_server_session_base_test.cc

Issue 1898793003: Make QuicDispatcher's helper and alarm factory arguments unique_ptrs to make ownership clear. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@119871679
Patch Set: fixing rebase Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « net/tools/quic/quic_server.cc ('k') | net/tools/quic/quic_server_test.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/tools/quic/quic_server_session_base_test.cc
diff --git a/net/tools/quic/quic_server_session_base_test.cc b/net/tools/quic/quic_server_session_base_test.cc
index 2e08f1443eb15711be71a71d2a7ca3207f4a84db..9601a5b1fb0a2a6cdb1f6d21d2a3ea854bde81e5 100644
--- a/net/tools/quic/quic_server_session_base_test.cc
+++ b/net/tools/quic/quic_server_session_base_test.cc
@@ -131,8 +131,9 @@ class QuicServerSessionBaseTest : public ::testing::TestWithParam<QuicVersion> {
config_.SetInitialSessionFlowControlWindowToSend(
kInitialSessionFlowControlWindowForTest);
- connection_ = new StrictMock<MockConnection>(
- &helper_, Perspective::IS_SERVER, SupportedVersions(GetParam()));
+ connection_ = new StrictMock<MockConnection>(&helper_, &alarm_factory_,
+ Perspective::IS_SERVER,
+ SupportedVersions(GetParam()));
session_.reset(new TestServerSession(config_, connection_, &owner_,
&crypto_config_,
&compressed_certs_cache_));
@@ -146,6 +147,7 @@ class QuicServerSessionBaseTest : public ::testing::TestWithParam<QuicVersion> {
StrictMock<MockQuicServerSessionVisitor> owner_;
MockConnectionHelper helper_;
+ MockAlarmFactory alarm_factory_;
StrictMock<MockConnection>* connection_;
QuicConfig config_;
QuicCryptoServerConfig crypto_config_;
« no previous file with comments | « net/tools/quic/quic_server.cc ('k') | net/tools/quic/quic_server_test.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698