Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(256)

Unified Diff: net/quic/quic_stream_factory.h

Issue 1898793003: Make QuicDispatcher's helper and alarm factory arguments unique_ptrs to make ownership clear. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@119871679
Patch Set: fixing rebase Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « net/quic/quic_spdy_stream_test.cc ('k') | net/quic/quic_stream_factory.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/quic/quic_stream_factory.h
diff --git a/net/quic/quic_stream_factory.h b/net/quic/quic_stream_factory.h
index c7f10d121f68ae8f22f9cb5242cd8dda62f4b3b5..5c0ae0d76967974cc94045289af9b9e3923276b5 100644
--- a/net/quic/quic_stream_factory.h
+++ b/net/quic/quic_stream_factory.h
@@ -48,6 +48,7 @@ class CTVerifier;
class HostResolver;
class HttpServerProperties;
class QuicClock;
+class QuicChromiumAlarmFactory;
class QuicChromiumClientSession;
class QuicChromiumConnectionHelper;
class QuicCryptoClientStreamFactory;
@@ -304,6 +305,7 @@ class NET_EXPORT_PRIVATE QuicStreamFactory
base::TimeDelta GetTimeDelayForWaitingJob(const QuicServerId& server_id);
QuicChromiumConnectionHelper* helper() { return helper_.get(); }
+ QuicChromiumAlarmFactory* alarm_factory() { return alarm_factory_.get(); }
bool enable_port_selection() const { return enable_port_selection_; }
@@ -429,7 +431,8 @@ class NET_EXPORT_PRIVATE QuicStreamFactory
// The helper used for all connections.
std::unique_ptr<QuicChromiumConnectionHelper> helper_;
-
+ // The alarm factory used for all connnections.
+ std::unique_ptr<QuicChromiumAlarmFactory> alarm_factory_;
// Contains owning pointers to all sessions that currently exist.
SessionIdMap all_sessions_;
// Contains non-owning pointers to currently active session
« no previous file with comments | « net/quic/quic_spdy_stream_test.cc ('k') | net/quic/quic_stream_factory.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698