Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(362)

Unified Diff: net/quic/reliable_quic_stream_test.cc

Issue 1898793003: Make QuicDispatcher's helper and alarm factory arguments unique_ptrs to make ownership clear. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@119871679
Patch Set: fixing rebase Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « net/quic/quic_stream_sequencer_test.cc ('k') | net/quic/test_tools/crypto_test_utils.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/quic/reliable_quic_stream_test.cc
diff --git a/net/quic/reliable_quic_stream_test.cc b/net/quic/reliable_quic_stream_test.cc
index a4bd67d8ac35ca625f1f6b71e888bd337c90270d..12164b0b5f76ca5677e9f9da55ebb1765bd30a88 100644
--- a/net/quic/reliable_quic_stream_test.cc
+++ b/net/quic/reliable_quic_stream_test.cc
@@ -104,7 +104,7 @@ class ReliableQuicStreamTest : public ::testing::TestWithParam<bool> {
void Initialize(bool stream_should_process_data) {
connection_ = new StrictMock<MockConnection>(
- &helper_, Perspective::IS_SERVER, supported_versions_);
+ &helper_, &alarm_factory_, Perspective::IS_SERVER, supported_versions_);
session_.reset(new StrictMock<MockQuicSpdySession>(connection_));
// New streams rely on having the peer's flow control receive window
@@ -148,6 +148,7 @@ class ReliableQuicStreamTest : public ::testing::TestWithParam<bool> {
protected:
MockConnectionHelper helper_;
+ MockAlarmFactory alarm_factory_;
MockConnection* connection_;
std::unique_ptr<MockQuicSpdySession> session_;
TestStream* stream_;
« no previous file with comments | « net/quic/quic_stream_sequencer_test.cc ('k') | net/quic/test_tools/crypto_test_utils.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698