Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(279)

Unified Diff: net/quic/quic_spdy_stream_test.cc

Issue 1898793003: Make QuicDispatcher's helper and alarm factory arguments unique_ptrs to make ownership clear. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@119871679
Patch Set: fixing rebase Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « net/quic/quic_session_test.cc ('k') | net/quic/quic_stream_factory.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/quic/quic_spdy_stream_test.cc
diff --git a/net/quic/quic_spdy_stream_test.cc b/net/quic/quic_spdy_stream_test.cc
index d01a2cd23938b5e82c70e5490d11db7d693e08dd..9379f62c8cab554b66e3a9225de094e134f02639 100644
--- a/net/quic/quic_spdy_stream_test.cc
+++ b/net/quic/quic_spdy_stream_test.cc
@@ -97,7 +97,8 @@ class QuicSpdyStreamTest : public ::testing::TestWithParam<QuicVersion> {
void Initialize(bool stream_should_process_data) {
connection_ = new testing::StrictMock<MockConnection>(
- &helper_, Perspective::IS_SERVER, SupportedVersions(GetParam()));
+ &helper_, &alarm_factory_, Perspective::IS_SERVER,
+ SupportedVersions(GetParam()));
session_.reset(new testing::StrictMock<MockQuicSpdySession>(connection_));
stream_ = new TestStream(kClientDataStreamId1, session_.get(),
stream_should_process_data);
@@ -109,6 +110,7 @@ class QuicSpdyStreamTest : public ::testing::TestWithParam<QuicVersion> {
protected:
MockConnectionHelper helper_;
+ MockAlarmFactory alarm_factory_;
MockConnection* connection_;
std::unique_ptr<MockQuicSpdySession> session_;
« no previous file with comments | « net/quic/quic_session_test.cc ('k') | net/quic/quic_stream_factory.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698