net/tools/quic/quic_simple_client.h - Issue 1898793003: Make QuicDispatcher's helper and alarm factory arguments unique_ptrs to make ownership clear.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: net/tools/quic/quic_simple_client.h

Issue 1898793003: Make QuicDispatcher's helper and alarm factory arguments unique_ptrs to make ownership clear. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@119871679

Patch Set: fixing rebase Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: net/tools/quic/quic_simple_client.h

diff --git a/net/tools/quic/quic_simple_client.h b/net/tools/quic/quic_simple_client.h

index bcd0bdabe0f4f18c29ed405abb4b012d8e3756f4..77c16c710ab88dd90b3e83aa08bf620a026c319e 100644

--- a/net/tools/quic/quic_simple_client.h

+++ b/net/tools/quic/quic_simple_client.h

@@ -28,6 +28,7 @@

namespace net {

struct HttpRequestInfo;

+class QuicChromiumAlarmFactory;

class QuicChromiumConnectionHelper;

class UDPClientSocket;

@@ -167,6 +168,7 @@ class QuicSimpleClient : public QuicClientBase,

protected:

virtual QuicChromiumConnectionHelper* CreateQuicConnectionHelper();

+ virtual QuicChromiumAlarmFactory* CreateQuicAlarmFactory();

virtual QuicPacketWriter* CreateQuicPacketWriter();

private:

« no previous file with comments | « net/tools/quic/quic_server_test.cc ('k') | net/tools/quic/quic_simple_client.cc » ('j') | no next file with comments »