net/tools/quic/quic_time_wait_list_manager.cc - Issue 1898793003: Make QuicDispatcher's helper and alarm factory arguments unique_ptrs to make ownership clear.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: net/tools/quic/quic_time_wait_list_manager.cc

Issue 1898793003: Make QuicDispatcher's helper and alarm factory arguments unique_ptrs to make ownership clear. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@119871679

Patch Set: fixing rebase Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: net/tools/quic/quic_time_wait_list_manager.cc

diff --git a/net/tools/quic/quic_time_wait_list_manager.cc b/net/tools/quic/quic_time_wait_list_manager.cc

index 38badb1701941db88798bcaec174c45defe6a375..8edd2db7cf7fbdf46a5165c31e631c668e4e201b 100644

--- a/net/tools/quic/quic_time_wait_list_manager.cc

+++ b/net/tools/quic/quic_time_wait_list_manager.cc

@@ -76,11 +76,12 @@ class QuicTimeWaitListManager::QueuedPacket {

QuicTimeWaitListManager::QuicTimeWaitListManager(

QuicPacketWriter* writer,

QuicServerSessionVisitor* visitor,

- QuicConnectionHelperInterface* helper)

+ QuicConnectionHelperInterface* helper,

+ QuicAlarmFactory* alarm_factory)

: time_wait_period_(

QuicTime::Delta::FromSeconds(FLAGS_quic_time_wait_list_seconds)),

connection_id_clean_up_alarm_(

- helper->CreateAlarm(new ConnectionIdCleanUpAlarm(this))),

+ alarm_factory->CreateAlarm(new ConnectionIdCleanUpAlarm(this))),

clock_(helper->GetClock()),

writer_(writer),

visitor_(visitor) {

« no previous file with comments | « net/tools/quic/quic_time_wait_list_manager.h ('k') | net/tools/quic/quic_time_wait_list_manager_test.cc » ('j') | no next file with comments »