Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(353)

Unified Diff: net/quic/quic_flow_controller_test.cc

Issue 1898793003: Make QuicDispatcher's helper and alarm factory arguments unique_ptrs to make ownership clear. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@119871679
Patch Set: fixing rebase Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « net/quic/quic_epoll_alarm_factory_test.cc ('k') | net/quic/quic_headers_stream_test.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/quic/quic_flow_controller_test.cc
diff --git a/net/quic/quic_flow_controller_test.cc b/net/quic/quic_flow_controller_test.cc
index b189a4082e89a3e7b3b28b6befd7e537826a52af..3f8b13c8fb63586acc584e66008e359a5c7268e3 100644
--- a/net/quic/quic_flow_controller_test.cc
+++ b/net/quic/quic_flow_controller_test.cc
@@ -29,7 +29,7 @@ class QuicFlowControllerTest : public ::testing::Test {
: stream_id_(1234),
send_window_(kInitialSessionFlowControlWindowForTest),
receive_window_(kInitialSessionFlowControlWindowForTest),
- connection_(&helper_, Perspective::IS_CLIENT) {}
+ connection_(&helper_, &alarm_factory_, Perspective::IS_CLIENT) {}
void Initialize() {
flow_controller_.reset(
@@ -43,6 +43,7 @@ class QuicFlowControllerTest : public ::testing::Test {
QuicByteCount receive_window_;
std::unique_ptr<QuicFlowController> flow_controller_;
MockConnectionHelper helper_;
+ MockAlarmFactory alarm_factory_;
MockConnection connection_;
};
« no previous file with comments | « net/quic/quic_epoll_alarm_factory_test.cc ('k') | net/quic/quic_headers_stream_test.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698