Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(187)

Side by Side Diff: net/quic/quic_stream_factory.h

Issue 1898793003: Make QuicDispatcher's helper and alarm factory arguments unique_ptrs to make ownership clear. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@119871679
Patch Set: fixing rebase Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « net/quic/quic_spdy_stream_test.cc ('k') | net/quic/quic_stream_factory.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef NET_QUIC_QUIC_STREAM_FACTORY_H_ 5 #ifndef NET_QUIC_QUIC_STREAM_FACTORY_H_
6 #define NET_QUIC_QUIC_STREAM_FACTORY_H_ 6 #define NET_QUIC_QUIC_STREAM_FACTORY_H_
7 7
8 #include <stddef.h> 8 #include <stddef.h>
9 #include <stdint.h> 9 #include <stdint.h>
10 10
(...skipping 30 matching lines...) Expand all
41 namespace net { 41 namespace net {
42 42
43 class CTPolicyEnforcer; 43 class CTPolicyEnforcer;
44 class CertVerifier; 44 class CertVerifier;
45 class ChannelIDService; 45 class ChannelIDService;
46 class ClientSocketFactory; 46 class ClientSocketFactory;
47 class CTVerifier; 47 class CTVerifier;
48 class HostResolver; 48 class HostResolver;
49 class HttpServerProperties; 49 class HttpServerProperties;
50 class QuicClock; 50 class QuicClock;
51 class QuicChromiumAlarmFactory;
51 class QuicChromiumClientSession; 52 class QuicChromiumClientSession;
52 class QuicChromiumConnectionHelper; 53 class QuicChromiumConnectionHelper;
53 class QuicCryptoClientStreamFactory; 54 class QuicCryptoClientStreamFactory;
54 class QuicRandom; 55 class QuicRandom;
55 class QuicServerId; 56 class QuicServerId;
56 class QuicServerInfo; 57 class QuicServerInfo;
57 class QuicServerInfoFactory; 58 class QuicServerInfoFactory;
58 class QuicStreamFactory; 59 class QuicStreamFactory;
59 class SocketPerformanceWatcherFactory; 60 class SocketPerformanceWatcherFactory;
60 class TransportSecurityState; 61 class TransportSecurityState;
(...skipping 236 matching lines...) Expand 10 before | Expand all | Expand 10 after
297 bool require_confirmation() const { return require_confirmation_; } 298 bool require_confirmation() const { return require_confirmation_; }
298 299
299 void set_require_confirmation(bool require_confirmation); 300 void set_require_confirmation(bool require_confirmation);
300 301
301 bool ZeroRTTEnabledFor(const QuicServerId& server_id); 302 bool ZeroRTTEnabledFor(const QuicServerId& server_id);
302 303
303 // It returns the amount of time waiting job should be delayed. 304 // It returns the amount of time waiting job should be delayed.
304 base::TimeDelta GetTimeDelayForWaitingJob(const QuicServerId& server_id); 305 base::TimeDelta GetTimeDelayForWaitingJob(const QuicServerId& server_id);
305 306
306 QuicChromiumConnectionHelper* helper() { return helper_.get(); } 307 QuicChromiumConnectionHelper* helper() { return helper_.get(); }
308 QuicChromiumAlarmFactory* alarm_factory() { return alarm_factory_.get(); }
307 309
308 bool enable_port_selection() const { return enable_port_selection_; } 310 bool enable_port_selection() const { return enable_port_selection_; }
309 311
310 bool has_quic_server_info_factory() { 312 bool has_quic_server_info_factory() {
311 return quic_server_info_factory_.get() != nullptr; 313 return quic_server_info_factory_.get() != nullptr;
312 } 314 }
313 315
314 void set_quic_server_info_factory( 316 void set_quic_server_info_factory(
315 QuicServerInfoFactory* quic_server_info_factory); 317 QuicServerInfoFactory* quic_server_info_factory);
316 318
(...skipping 105 matching lines...) Expand 10 before | Expand all | Expand 10 after
422 std::unique_ptr<QuicClock> clock_; 424 std::unique_ptr<QuicClock> clock_;
423 const size_t max_packet_length_; 425 const size_t max_packet_length_;
424 426
425 // Factory which is used to create socket performance watcher. A new watcher 427 // Factory which is used to create socket performance watcher. A new watcher
426 // is created for every QUIC connection. 428 // is created for every QUIC connection.
427 // |socket_performance_watcher_factory_| may be null. 429 // |socket_performance_watcher_factory_| may be null.
428 SocketPerformanceWatcherFactory* socket_performance_watcher_factory_; 430 SocketPerformanceWatcherFactory* socket_performance_watcher_factory_;
429 431
430 // The helper used for all connections. 432 // The helper used for all connections.
431 std::unique_ptr<QuicChromiumConnectionHelper> helper_; 433 std::unique_ptr<QuicChromiumConnectionHelper> helper_;
432 434 // The alarm factory used for all connnections.
435 std::unique_ptr<QuicChromiumAlarmFactory> alarm_factory_;
433 // Contains owning pointers to all sessions that currently exist. 436 // Contains owning pointers to all sessions that currently exist.
434 SessionIdMap all_sessions_; 437 SessionIdMap all_sessions_;
435 // Contains non-owning pointers to currently active session 438 // Contains non-owning pointers to currently active session
436 // (not going away session, once they're implemented). 439 // (not going away session, once they're implemented).
437 SessionMap active_sessions_; 440 SessionMap active_sessions_;
438 // Map from session to set of aliases that this session is known by. 441 // Map from session to set of aliases that this session is known by.
439 SessionAliasMap session_aliases_; 442 SessionAliasMap session_aliases_;
440 // Map from IP address to sessions which are connected to this address. 443 // Map from IP address to sessions which are connected to this address.
441 IPAliasMap ip_aliases_; 444 IPAliasMap ip_aliases_;
442 445
(...skipping 115 matching lines...) Expand 10 before | Expand all | Expand 10 after
558 base::TaskRunner* task_runner_; 561 base::TaskRunner* task_runner_;
559 562
560 base::WeakPtrFactory<QuicStreamFactory> weak_factory_; 563 base::WeakPtrFactory<QuicStreamFactory> weak_factory_;
561 564
562 DISALLOW_COPY_AND_ASSIGN(QuicStreamFactory); 565 DISALLOW_COPY_AND_ASSIGN(QuicStreamFactory);
563 }; 566 };
564 567
565 } // namespace net 568 } // namespace net
566 569
567 #endif // NET_QUIC_QUIC_STREAM_FACTORY_H_ 570 #endif // NET_QUIC_QUIC_STREAM_FACTORY_H_
OLDNEW
« no previous file with comments | « net/quic/quic_spdy_stream_test.cc ('k') | net/quic/quic_stream_factory.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698