Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(126)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1885973002: Remove implicit cast from CFX_ByteString to (const char*). (Closed)

Created:
4 years, 8 months ago by Tom Sepez
Modified:
4 years, 8 months ago
Reviewers:
Lei Zhang
CC:
pdfium-reviews_googlegroups.com
Base URL:
https://pdfium.googlesource.com/pdfium.git@master
Target Ref:
refs/heads/master
Project:
pdfium
Visibility:
Public.

Description

Remove implicit cast from CFX_ByteString to (const char*). BUG= Committed: https://pdfium.googlesource.com/pdfium/+/b4c9f3f04673753da30011e9f1282cd5d1fa0f40

Patch Set 1 #

Total comments: 1

Patch Set 2 : Apple error #1 #

Patch Set 3 : rebase #

Patch Set 4 : Win error #1 #

Patch Set 5 : Win error #2 #

Total comments: 4

Patch Set 6 : Reuse AsStringC() result. #

Patch Set 7 : Typo #

Unified diffs Side-by-side diffs Delta from patch set Stats (+148 lines, -146 lines) Patch
M core/fpdfapi/fpdf_font/cpdf_font.cpp View 1 chunk +1 line, -1 line 0 comments Download
M core/fpdfapi/fpdf_font/cpdf_type3font.cpp View 1 chunk +2 lines, -1 line 0 comments Download
M core/fpdfapi/fpdf_font/fpdf_font_cid.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M core/fpdfapi/fpdf_page/cpdf_textobject.cpp View 3 chunks +5 lines, -4 lines 0 comments Download
M core/fpdfapi/fpdf_parser/cfdf_document.cpp View 1 chunk +1 line, -1 line 0 comments Download
M core/fpdfapi/fpdf_parser/cpdf_data_avail.cpp View 5 chunks +5 lines, -5 lines 0 comments Download
M core/fpdfapi/fpdf_parser/cpdf_parser.cpp View 9 chunks +10 lines, -10 lines 0 comments Download
M core/fpdfapi/fpdf_parser/cpdf_syntax_parser.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M core/fpdfapi/fpdf_parser/fpdf_parser_utility.cpp View 1 chunk +1 line, -1 line 0 comments Download
M core/fpdfapi/fpdf_render/fpdf_render_text.cpp View 3 chunks +3 lines, -3 lines 0 comments Download
M core/fpdfdoc/doc_basic.cpp View 1 chunk +1 line, -1 line 0 comments Download
M core/fpdfdoc/doc_form.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M core/fpdfdoc/doc_utils.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M core/fpdftext/fpdf_text_int.cpp View 1 chunk +1 line, -1 line 0 comments Download
M core/fxcrt/fx_basic_bstring.cpp View 1 chunk +1 line, -1 line 0 comments Download
M core/fxcrt/fx_basic_gcc.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M core/fxcrt/fx_basic_util.cpp View 1 2 3 4 2 chunks +4 lines, -4 lines 0 comments Download
M core/fxcrt/include/fx_string.h View 1 chunk +0 lines, -3 lines 0 comments Download
M core/fxge/apple/fx_mac_imp.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
M core/fxge/ge/fx_ge_fontmap.cpp View 10 chunks +13 lines, -13 lines 0 comments Download
M core/fxge/win32/fx_win32_device.cpp View 1 2 3 2 chunks +4 lines, -3 lines 0 comments Download
M core/fxge/win32/fx_win32_gdipext.cpp View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M fpdfsdk/fpdf_sysfontinfo.cpp View 1 chunk +1 line, -1 line 0 comments Download
M fpdfsdk/fpdfformfill.cpp View 1 chunk +1 line, -2 lines 0 comments Download
M fpdfsdk/fpdfppo.cpp View 1 2 3 4 5 6 5 chunks +13 lines, -11 lines 0 comments Download
M fpdfsdk/fpdfxfa/fpdfxfa_doc.cpp View 1 2 3 4 5 4 chunks +7 lines, -8 lines 0 comments Download
M fpdfsdk/fsdk_actionhandler.cpp View 1 chunk +1 line, -1 line 0 comments Download
M fpdfsdk/fsdk_mgr.cpp View 1 chunk +2 lines, -1 line 0 comments Download
M fpdfsdk/javascript/PublicMethods.cpp View 6 chunks +9 lines, -8 lines 0 comments Download
M fpdfsdk/javascript/global.cpp View 1 chunk +1 line, -1 line 0 comments Download
M fpdfsdk/pdfwindow/PWL_FontMap.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M xfa/fgas/crt/fgas_codepage.cpp View 1 chunk +1 line, -1 line 0 comments Download
M xfa/fgas/crt/fgas_stream.cpp View 2 chunks +4 lines, -6 lines 0 comments Download
M xfa/fgas/font/fgas_stdfontmgr.cpp View 7 chunks +10 lines, -9 lines 0 comments Download
M xfa/fxbarcode/oned/BC_OnedCode128Writer.cpp View 1 chunk +1 line, -1 line 0 comments Download
M xfa/fxbarcode/oned/BC_OnedEAN13Writer.cpp View 4 chunks +5 lines, -5 lines 0 comments Download
M xfa/fxbarcode/oned/BC_OnedEAN8Writer.cpp View 3 chunks +4 lines, -4 lines 0 comments Download
M xfa/fxbarcode/oned/BC_OnedUPCAWriter.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M xfa/fxfa/app/xfa_ffdoc.cpp View 1 chunk +2 lines, -3 lines 0 comments Download
M xfa/fxfa/app/xfa_ffwidget.cpp View 1 chunk +1 line, -1 line 0 comments Download
M xfa/fxfa/fm2js/xfa_fm2jscontext.cpp View 5 chunks +8 lines, -8 lines 0 comments Download
M xfa/fxfa/parser/xfa_locale.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M xfa/fxfa/parser/xfa_object_imp.cpp View 1 chunk +1 line, -1 line 0 comments Download
M xfa/fxfa/parser/xfa_script_imp.cpp View 2 chunks +4 lines, -2 lines 0 comments Download
M xfa/fxjse/class.cpp View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 10 (4 generated)
Tom Sepez
Lei, for review. May take some iteration to get other platforms clean. https://codereview.chromium.org/1885973002/diff/1/core/fxcrt/include/fx_string.h File core/fxcrt/include/fx_string.h ...
4 years, 8 months ago (2016-04-13 18:26:38 UTC) #2
Tom Sepez
Lei, it's green. thanks.
4 years, 8 months ago (2016-04-13 20:51:40 UTC) #3
Lei Zhang
lgtm https://codereview.chromium.org/1885973002/diff/80001/fpdfsdk/fpdfppo.cpp File fpdfsdk/fpdfppo.cpp (right): https://codereview.chromium.org/1885973002/diff/80001/fpdfsdk/fpdfppo.cpp#newcode194 fpdfsdk/fpdfppo.cpp:194: if (pDict->KeyExist(nSrctag.AsStringC())) Call AsStringC once and reuse the ...
4 years, 8 months ago (2016-04-13 21:54:59 UTC) #4
Tom Sepez
https://codereview.chromium.org/1885973002/diff/80001/fpdfsdk/fpdfppo.cpp File fpdfsdk/fpdfppo.cpp (right): https://codereview.chromium.org/1885973002/diff/80001/fpdfsdk/fpdfppo.cpp#newcode194 fpdfsdk/fpdfppo.cpp:194: if (pDict->KeyExist(nSrctag.AsStringC())) On 2016/04/13 21:54:58, Lei Zhang wrote: > ...
4 years, 8 months ago (2016-04-13 22:25:20 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1885973002/120001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1885973002/120001
4 years, 8 months ago (2016-04-13 22:41:01 UTC) #8
commit-bot: I haz the power
4 years, 8 months ago (2016-04-13 22:41:26 UTC) #10
Message was sent while issue was closed. 
Committed patchset #7 (id:120001) as
https://pdfium.googlesource.com/pdfium/+/b4c9f3f04673753da30011e9f1282cd5d1fa...

Powered by Google App Engine
This is Rietveld 408576698