core/fxcrt/fx_basic_bstring.cpp - Issue 1885973002: Remove implicit cast from CFX_ByteString to (const char*).

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: core/fxcrt/fx_basic_bstring.cpp

Issue 1885973002: Remove implicit cast from CFX_ByteString to (const char*). (Closed) Base URL: https://pdfium.googlesource.com/pdfium.git@master

Patch Set: Typo Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: core/fxcrt/fx_basic_bstring.cpp

diff --git a/core/fxcrt/fx_basic_bstring.cpp b/core/fxcrt/fx_basic_bstring.cpp

index 23fdcaa25ea02266385a1640b9c8adf78c4c0a51..bfa0cbd98cea2c928f382ecb3ce06e5ae324d8ba 100644

--- a/core/fxcrt/fx_basic_bstring.cpp

+++ b/core/fxcrt/fx_basic_bstring.cpp

@@ -921,7 +921,7 @@ void CFX_ByteString::TrimLeft() {

}

uint32_t CFX_ByteString::GetID(FX_STRSIZE start_pos) const {

- return CFX_ByteStringC(*this).GetID(start_pos);

+ return AsStringC().GetID(start_pos);

}

uint32_t CFX_ByteStringC::GetID(FX_STRSIZE start_pos) const {

if (m_Length == 0) {

« no previous file with comments | « core/fpdftext/fpdf_text_int.cpp ('k') | core/fxcrt/fx_basic_gcc.cpp » ('j') | no next file with comments »