Remove implicit cast from CFX_ByteString to (const char*).

xfa/fxfa/fm2js/xfa_fm2jscontext.cpp

 // Copyright 2014 PDFium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // Original code copyright 2014 Foxit Software Inc. http://www.foxitsoftware.com
 
 #include "xfa/fxfa/fm2js/xfa_fm2jscontext.h"
 
 #include <time.h>
 
@@ skipping 3231 matching lines @@
     } else {
       CFX_WideTextBuf wsJavaScriptBuf;
       CFX_WideString javaScript;
       CFX_WideString wsError;
       XFA_FM2JS_Translate(
           CFX_WideString::FromUTF8(utf8ScriptString.AsStringC()).AsStringC(),
           wsJavaScriptBuf, wsError);
       FXJSE_HCONTEXT hContext = FXJSE_Context_Create(hruntime);
       FXJSE_HVALUE returnValue = FXJSE_Value_Create(hruntime);
       javaScript = wsJavaScriptBuf.GetWideString();
-      FXJSE_ExecuteScript(hContext,
-                          FX_UTF8Encode(javaScript, javaScript.GetLength()),
-                          returnValue);
+      FXJSE_ExecuteScript(
+          hContext, FX_UTF8Encode(javaScript, javaScript.GetLength()).c_str(),
+          returnValue);
       FXJSE_Value_Set(args.GetReturnValue(), returnValue);
       FXJSE_Value_Release(returnValue);
       FXJSE_Context_Release(hContext);
     }
     FXJSE_Value_Release(scriptValue);
   } else {
     pContext->ThrowScriptErrorMessage(XFA_IDS_INCORRECT_NUMBER_OF_METHOD,
                                       L"Eval");
   }
 }
@@ skipping 198 matching lines @@
     FXJSE_HVALUE unitspanValue = GetSimpleHValue(hThis, args, 0);
     FXJSE_HVALUE unitValue = 0;
     CFX_ByteString unitspanString;
     FX_DOUBLE dFirstNumber = 0;
     CFX_ByteString strFirstUnit;
     CFX_ByteString strUnit;
     if (FXJSE_Value_IsNull(unitspanValue)) {
       FXJSE_Value_SetNull(args.GetReturnValue());
     } else {
       HValueToUTF8String(unitspanValue, unitspanString);
-      const FX_CHAR* pData = unitspanString;
+      const FX_CHAR* pData = unitspanString.c_str();
       if (pData) {
         int32_t u = 0;
         while (*(pData + u) == 0x20 || *(pData + u) == 0x09 ||
                *(pData + u) == 0x0B || *(pData + u) == 0x0C ||
                *(pData + u) == 0x0A || *(pData + u) == 0x0D) {
           ++u;
         }
         while (u < unitspanString.GetLength()) {
           if ((*(pData + u) > '9' || *(pData + u) < '0') &&
               *(pData + u) != '.' && *(pData + u) != '-') {
@@ skipping 14 matching lines @@
             break;
           }
           strFirstUnit += (*(pData + u));
           ++u;
         }
         strFirstUnit.MakeLower();
         if (argc == 2) {
           unitValue = GetSimpleHValue(hThis, args, 1);
           CFX_ByteString unitTempString;
           HValueToUTF8String(unitValue, unitTempString);
-          const FX_CHAR* pData = unitTempString;
+          const FX_CHAR* pData = unitTempString.c_str();
           int32_t u = 0;
           while (*(pData + u) == ' ' || *(pData + u) == 0x09 ||
                  *(pData + u) == 0x0B || *(pData + u) == 0x0C ||
                  *(pData + u) == 0x0A || *(pData + u) == 0x0D) {
             ++u;
           }
           while (u < unitTempString.GetLength()) {
             if ((*(pData + u) > '9' || *(pData + u) < '0') &&
                 *(pData + u) != '.') {
               break;
@@ skipping 1378 matching lines @@
       }
     }
     if (!bFlags) {
       CFX_ByteString numberString;
       CFX_ByteString formatStr = "%";
       if (iPrecision) {
         formatStr += ".";
         formatStr += CFX_ByteString::FormatInteger(iPrecision);
       }
       formatStr += "f";
-      numberString.Format(formatStr, fNumber);
-      const FX_CHAR* pData = numberString;
+      numberString.Format(formatStr.c_str(), fNumber);
+      const FX_CHAR* pData = numberString.c_str();
       int32_t iLength = numberString.GetLength();
       int32_t u = 0;
       while (u < iLength) {
         if (*(pData + u) == '.') {
           break;
         }
         ++u;
       }
       CFX_ByteTextBuf resultBuf;
       if (u > iWidth || (iPrecision + u) >= iWidth) {
@@ skipping 2064 matching lines @@
     return iValue;
   } else if (FXJSE_Value_IsObject(hValue)) {
     FXJSE_HVALUE newProperty = FXJSE_Value_Create(hruntime);
     GetObjectDefaultValue(hValue, newProperty);
     iValue = HValueToInteger(hThis, newProperty);
     FXJSE_Value_Release(newProperty);
     return iValue;
   } else if (FXJSE_Value_IsUTF8String(hValue)) {
     CFX_ByteString szValue;
     FXJSE_Value_ToUTF8String(hValue, szValue);
-    iValue = FXSYS_atoi(szValue);
+    iValue = FXSYS_atoi(szValue.c_str());
   } else {
     iValue = FXJSE_Value_ToInteger(hValue);
   }
   return iValue;
 }
 FX_DOUBLE CXFA_FM2JSContext::StringToDouble(
     const CFX_ByteStringC& szStringVal) {
   return XFA_ByteStringToDouble(szStringVal);
 }
 FX_FLOAT CXFA_FM2JSContext::HValueToFloat(FXJSE_HOBJECT hThis,
@@ skipping 224 matching lines @@
   CFX_WideString wsFormat;
   pAppProvider->LoadString(iStringID, wsFormat);
   CFX_WideString wsMessage;
   va_list arg_ptr;
   va_start(arg_ptr, iStringID);
   wsMessage.FormatV((const FX_WCHAR*)wsFormat, arg_ptr);
   va_end(arg_ptr);
   FXJSE_ThrowMessage(
       "", FX_UTF8Encode(wsMessage, wsMessage.GetLength()).AsStringC());
 }