fpdfsdk/javascript/global.cpp - Issue 1885973002: Remove implicit cast from CFX_ByteString to (const char*).

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: fpdfsdk/javascript/global.cpp

Issue 1885973002: Remove implicit cast from CFX_ByteString to (const char*). (Closed) Base URL: https://pdfium.googlesource.com/pdfium.git@master

Patch Set: Typo Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: fpdfsdk/javascript/global.cpp

diff --git a/fpdfsdk/javascript/global.cpp b/fpdfsdk/javascript/global.cpp

index d843b60105fe8e8e03e14a3f587575e6a5b0e465..7242a144c98c2b54463fb5e834e8be61de57a664 100644

--- a/fpdfsdk/javascript/global.cpp

+++ b/fpdfsdk/javascript/global.cpp

@@ -414,7 +414,7 @@ FX_BOOL JSGlobalAlternate::SetGlobalVariables(const CFX_ByteString& propname,

const CFX_ByteString& sData,

v8::Local<v8::Object> pData,

bool bDefaultPersistent) {

- if (!propname)

+ if (propname.IsEmpty())

return FALSE;

auto it = m_mapGlobal.find(propname);

« no previous file with comments | « fpdfsdk/javascript/PublicMethods.cpp ('k') | fpdfsdk/pdfwindow/PWL_FontMap.cpp » ('j') | no next file with comments »