core/fpdfapi/fpdf_font/cpdf_font.cpp - Issue 1885973002: Remove implicit cast from CFX_ByteString to (const char*).

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: core/fpdfapi/fpdf_font/cpdf_font.cpp

Issue 1885973002: Remove implicit cast from CFX_ByteString to (const char*). (Closed) Base URL: https://pdfium.googlesource.com/pdfium.git@master

Patch Set: Typo Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: core/fpdfapi/fpdf_font/cpdf_font.cpp

diff --git a/core/fpdfapi/fpdf_font/cpdf_font.cpp b/core/fpdfapi/fpdf_font/cpdf_font.cpp

index 7a6043ad8786ec6e9b3a0d29ff5ff32aca1c397d..3dfadeda9e0a74189b2e8f3a38548451259e1887 100644

--- a/core/fpdfapi/fpdf_font/cpdf_font.cpp

+++ b/core/fpdfapi/fpdf_font/cpdf_font.cpp

@@ -485,7 +485,7 @@ const FX_CHAR* CPDF_Font::GetAdobeCharName(int iBaseEncoding,

const FX_CHAR* name = nullptr;

if (pCharNames)

- name = pCharNames[charcode];

+ name = pCharNames[charcode].c_str();

if ((!name || name[0] == 0) && iBaseEncoding)

name = PDF_CharNameFromPredefinedCharSet(iBaseEncoding, charcode);

return name && name[0] ? name : nullptr;

« no previous file with comments | « no previous file | core/fpdfapi/fpdf_font/cpdf_type3font.cpp » ('j') | no next file with comments »