xfa/fxfa/parser/xfa_object_imp.cpp - Issue 1885973002: Remove implicit cast from CFX_ByteString to (const char*).

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: xfa/fxfa/parser/xfa_object_imp.cpp

Issue 1885973002: Remove implicit cast from CFX_ByteString to (const char*). (Closed) Base URL: https://pdfium.googlesource.com/pdfium.git@master

Patch Set: Typo Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: xfa/fxfa/parser/xfa_object_imp.cpp

diff --git a/xfa/fxfa/parser/xfa_object_imp.cpp b/xfa/fxfa/parser/xfa_object_imp.cpp

index 8b8db882ea2c82f13d77875a2911cd5e50729733..157d7dfa57fcbd14ae6352b3fdce0a8f939a40f1 100644

--- a/xfa/fxfa/parser/xfa_object_imp.cpp

+++ b/xfa/fxfa/parser/xfa_object_imp.cpp

@@ -1730,7 +1730,7 @@ void CXFA_Node::Script_Boolean_Value(FXJSE_HVALUE hValue,

if (!(FXJSE_Value_IsNull(hValue) || FXJSE_Value_IsUndefined(hValue))) {

FXJSE_Value_ToUTF8String(hValue, newValue);

}

- int32_t iValue = FXSYS_atoi(newValue);

+ int32_t iValue = FXSYS_atoi(newValue.c_str());

CFX_WideString wsNewValue = (iValue == 0) ? FX_WSTRC(L"0") : FX_WSTRC(L"1");

CFX_WideString wsFormatValue(wsNewValue);

CXFA_WidgetData* pContainerWidgetData = GetContainerWidgetData();

« no previous file with comments | « xfa/fxfa/parser/xfa_locale.cpp ('k') | xfa/fxfa/parser/xfa_script_imp.cpp » ('j') | no next file with comments »