core/fpdftext/fpdf_text_int.cpp - Issue 1885973002: Remove implicit cast from CFX_ByteString to (const char*).

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: core/fpdftext/fpdf_text_int.cpp

Issue 1885973002: Remove implicit cast from CFX_ByteString to (const char*). (Closed) Base URL: https://pdfium.googlesource.com/pdfium.git@master

Patch Set: Typo Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: core/fpdftext/fpdf_text_int.cpp

diff --git a/core/fpdftext/fpdf_text_int.cpp b/core/fpdftext/fpdf_text_int.cpp

index 8d8fa4e9ed87eb321b2042a88c853e1376f863e9..a1e3fda7b1784106ed524901fa09410cdeddb41c 100644

--- a/core/fpdftext/fpdf_text_int.cpp

+++ b/core/fpdftext/fpdf_text_int.cpp

@@ -906,7 +906,7 @@ int CPDF_TextPage::GetCharWidth(uint32_t charCode, CPDF_Font* pFont) const {

CFX_ByteString str;

pFont->AppendChar(str, charCode);

- if (int w = pFont->GetStringWidth(str, 1))

+ if (int w = pFont->GetStringWidth(str.c_str(), 1))

return w;

return pFont->GetCharBBox(charCode).Width();

« no previous file with comments | « core/fpdfdoc/doc_utils.cpp ('k') | core/fxcrt/fx_basic_bstring.cpp » ('j') | no next file with comments »