core/fpdfapi/fpdf_parser/fpdf_parser_utility.cpp - Issue 1885973002: Remove implicit cast from CFX_ByteString to (const char*).

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: core/fpdfapi/fpdf_parser/fpdf_parser_utility.cpp

Issue 1885973002: Remove implicit cast from CFX_ByteString to (const char*). (Closed) Base URL: https://pdfium.googlesource.com/pdfium.git@master

Patch Set: Typo Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: core/fpdfapi/fpdf_parser/fpdf_parser_utility.cpp

diff --git a/core/fpdfapi/fpdf_parser/fpdf_parser_utility.cpp b/core/fpdfapi/fpdf_parser/fpdf_parser_utility.cpp

index bfd0de44b6d8a53e1469d4a1f4a5d6508246107d..466ccaffa592e754443f155cbd3739b8b9b61048 100644

--- a/core/fpdfapi/fpdf_parser/fpdf_parser_utility.cpp

+++ b/core/fpdfapi/fpdf_parser/fpdf_parser_utility.cpp

@@ -112,7 +112,7 @@ CFX_ByteString PDF_NameDecode(const CFX_ByteString& orig) {

if (!FXSYS_memchr(orig.c_str(), '#', orig.GetLength())) {

return orig;

}

- return PDF_NameDecode(CFX_ByteStringC(orig));

+ return PDF_NameDecode(orig.AsStringC());

}

CFX_ByteString PDF_NameEncode(const CFX_ByteString& orig) {