xfa/fxfa/app/xfa_ffdoc.cpp - Issue 1885973002: Remove implicit cast from CFX_ByteString to (const char*).

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: xfa/fxfa/app/xfa_ffdoc.cpp

Issue 1885973002: Remove implicit cast from CFX_ByteString to (const char*). (Closed) Base URL: https://pdfium.googlesource.com/pdfium.git@master

Patch Set: Typo Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: xfa/fxfa/app/xfa_ffdoc.cpp

diff --git a/xfa/fxfa/app/xfa_ffdoc.cpp b/xfa/fxfa/app/xfa_ffdoc.cpp

index 04fe075d2c4ac34276a3aa0439bcdc87151e4c39..c83895c25e99de3fd737f1ba4667f55c3d4be7d2 100644

--- a/xfa/fxfa/app/xfa_ffdoc.cpp

+++ b/xfa/fxfa/app/xfa_ffdoc.cpp

@@ -412,9 +412,8 @@ FX_BOOL CXFA_FFDoc::SavePackage(const CFX_WideStringC& wsPackage,

if (pCSContext) {

pCSContext->GetChecksum(bsChecksum);

}

- bFlags = pExport->Export(pFile, pNode, 0, bsChecksum.GetLength()

- ? (const FX_CHAR*)bsChecksum

- : NULL);

+ bFlags = pExport->Export(

+ pFile, pNode, 0, bsChecksum.GetLength() ? bsChecksum.c_str() : NULL);

} else {

bFlags = pExport->Export(pFile);

}

« no previous file with comments | « xfa/fxbarcode/oned/BC_OnedUPCAWriter.cpp ('k') | xfa/fxfa/app/xfa_ffwidget.cpp » ('j') | no next file with comments »