core/fpdfapi/fpdf_parser/cfdf_document.cpp - Issue 1885973002: Remove implicit cast from CFX_ByteString to (const char*).

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: core/fpdfapi/fpdf_parser/cfdf_document.cpp

Issue 1885973002: Remove implicit cast from CFX_ByteString to (const char*). (Closed) Base URL: https://pdfium.googlesource.com/pdfium.git@master

Patch Set: Typo Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: core/fpdfapi/fpdf_parser/cfdf_document.cpp

diff --git a/core/fpdfapi/fpdf_parser/cfdf_document.cpp b/core/fpdfapi/fpdf_parser/cfdf_document.cpp

index 9cbf999702882ea70c68636c714541e1404a4746..3039c329386283e8292867097b05d7720f4ad719 100644

--- a/core/fpdfapi/fpdf_parser/cfdf_document.cpp

+++ b/core/fpdfapi/fpdf_parser/cfdf_document.cpp

@@ -53,7 +53,7 @@ void CFDF_Document::ParseStream(IFX_FileRead* pFile, FX_BOOL bOwnFile) {

bool bNumber;

CFX_ByteString word = parser.GetNextWord(&bNumber);

if (bNumber) {

- uint32_t objnum = FXSYS_atoui(word);

+ uint32_t objnum = FXSYS_atoui(word.c_str());

word = parser.GetNextWord(&bNumber);

if (!bNumber) {

break;