Oilpan: Replace EAGERLY_FINALIZE in EventTarget's hierarchy with pre-finalizers

Oilpan: Replace EAGERLY_FINALIZE in EventTarget's hierarchy with pre-finalizers

This is a preparation for removing RefCountedGarbageCollectedEventTargetWithInlineData
(https://codereview.chromium.org/1857143002/). Because of MSVC's bug
(https://bugs.chromium.org/p/chromium/issues/detail?id=491995), we need to
remove template<typename T> from RefCountedGarbageCollectedEventTargetWithInlineData.
This means that we need to remove IsEagerlyFinalized<T> from RefCountedGarbageCollectedEventTargetWithInlineData.
So this CL replaces EAGERLY_FINALIZE in EventTarget's hierarchy with pre-finalizers.

BUG=585328
Committed: https://crrev.com/81ea6eb004c30f316611e9af3b556903483b6c97
Cr-Commit-Position: refs/heads/master@{#386344}

[haraken, 2016-04-11 06:11:14]

haraken@chromium.org changed reviewers:
+ oilpan-reviews@chromium.org, sigbjornf@opera.com

[haraken, 2016-04-11 06:11:15]

PTAL

[sof, 2016-04-11 06:23:32]

lgtm

https://codereview.chromium.org/1876703002/diff/1/third_party/WebKit/Source/m...
File third_party/WebKit/Source/modules/encryptedmedia/MediaKeySession.h (left):

https://codereview.chromium.org/1876703002/diff/1/third_party/WebKit/Source/m...
third_party/WebKit/Source/modules/encryptedmedia/MediaKeySession.h:96: //
Oilpan: eagerly release owned m_session, which in turn
It is worth preserving these EAGERLY_FINALIZE() comments, could you move them
'down' next to the dispose() operation (throughout this CL.)

https://codereview.chromium.org/1876703002/diff/1/third_party/WebKit/Source/m...
File third_party/WebKit/Source/modules/webmidi/MIDIAccess.h (left):

https://codereview.chromium.org/1876703002/diff/1/third_party/WebKit/Source/m...
third_party/WebKit/Source/modules/webmidi/MIDIAccess.h:99: // Eager finalization
needed to promptly release m_accessor. Otherwise
Move this comment down next to dispose() also?

[haraken, 2016-04-11 06:28:43]

>
https://codereview.chromium.org/1876703002/diff/1/third_party/WebKit/Source/m...
> File third_party/WebKit/Source/modules/encryptedmedia/MediaKeySession.h
(left):
> 
>
https://codereview.chromium.org/1876703002/diff/1/third_party/WebKit/Source/m...
> third_party/WebKit/Source/modules/encryptedmedia/MediaKeySession.h:96: //
> Oilpan: eagerly release owned m_session, which in turn
> It is worth preserving these EAGERLY_FINALIZE() comments, could you move them
> 'down' next to the dispose() operation (throughout this CL.)
> 
>
https://codereview.chromium.org/1876703002/diff/1/third_party/WebKit/Source/m...
> File third_party/WebKit/Source/modules/webmidi/MIDIAccess.h (left):
> 
>
https://codereview.chromium.org/1876703002/diff/1/third_party/WebKit/Source/m...
> third_party/WebKit/Source/modules/webmidi/MIDIAccess.h:99: // Eager
finalization
> needed to promptly release m_accessor. Otherwise
> Move this comment down next to dispose() also?

Done.

[haraken, 2016-04-11 06:28:47]

The CQ bit was checked by haraken@chromium.org

[haraken, 2016-04-11 06:28:47]

The patchset sent to the CQ was uploaded after l-g-t-m from sigbjornf@opera.com
Link to the patchset: https://codereview.chromium.org/1876703002/#ps20001
(title: " ")

[commit-bot: I haz the power, 2016-04-11 06:28:55]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1876703002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1876703002/20001

[commit-bot: I haz the power, 2016-04-11 07:37:01]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-04-11 07:38:21]

Description was changed from

==========
Oilpan: Replace EAGERLY_FINALIZE in EventTarget's hierarchy with pre-finalizers

This is a preparation for removing
RefCountedGarbageCollectedEventTargetWithInlineData
(https://codereview.chromium.org/1857143002/). Because of MSVC's bug
(https://bugs.chromium.org/p/chromium/issues/detail?id=491995), we need to
remove template<typename T> from
RefCountedGarbageCollectedEventTargetWithInlineData.
This means that we need to remove IsEagerlyFinalized<T> from
RefCountedGarbageCollectedEventTargetWithInlineData.
So this CL replaces EAGERLY_FINALIZE in EventTarget's hierarchy with
pre-finalizers.

BUG=585328
==========

to

==========
Oilpan: Replace EAGERLY_FINALIZE in EventTarget's hierarchy with pre-finalizers

This is a preparation for removing
RefCountedGarbageCollectedEventTargetWithInlineData
(https://codereview.chromium.org/1857143002/). Because of MSVC's bug
(https://bugs.chromium.org/p/chromium/issues/detail?id=491995), we need to
remove template<typename T> from
RefCountedGarbageCollectedEventTargetWithInlineData.
This means that we need to remove IsEagerlyFinalized<T> from
RefCountedGarbageCollectedEventTargetWithInlineData.
So this CL replaces EAGERLY_FINALIZE in EventTarget's hierarchy with
pre-finalizers.

BUG=585328

Committed: https://crrev.com/81ea6eb004c30f316611e9af3b556903483b6c97
Cr-Commit-Position: refs/heads/master@{#386344}
==========

[commit-bot: I haz the power, 2016-04-11 07:38:22]

Patchset 2 (id:??) landed as
https://crrev.com/81ea6eb004c30f316611e9af3b556903483b6c97
Cr-Commit-Position: refs/heads/master@{#386344}