Oilpan: Replace EAGERLY_FINALIZE in EventTarget's hierarchy with pre-finalizers

third_party/WebKit/Source/modules/encryptedmedia/MediaKeySession.h

 /*
  * Copyright (C) 2013 Apple Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions
  * are met:
  * 1. Redistributions of source code must retain the above copyright
  *    notice, this list of conditions and the following disclaimer.
  * 2. Redistributions in binary form must reproduce the above copyright
  *    notice, this list of conditions and the following disclaimer in the
@@ skipping 49 matching lines @@
 // it may outlive any JavaScript references as long as the MediaKeys object is alive.
 // The WebContentDecryptionModuleSession has the same lifetime as this object.
 class MediaKeySession final
     : public RefCountedGarbageCollectedEventTargetWithInlineData<MediaKeySession>
     , public ActiveScriptWrappable
     , public ActiveDOMObject
     , private WebContentDecryptionModuleSession::Client {
     REFCOUNTED_GARBAGE_COLLECTED_EVENT_TARGET(MediaKeySession);
     DEFINE_WRAPPERTYPEINFO();
     USING_GARBAGE_COLLECTED_MIXIN(MediaKeySession);
+    USING_PRE_FINALIZER(MediaKeySession, dispose);
 public:
     static MediaKeySession* create(ScriptState*, MediaKeys*, WebEncryptedMediaSessionType);
     ~MediaKeySession() override;
 
     String sessionId() const;
     double expiration() const { return m_expiration; }
     ScriptPromise closed(ScriptState*);
     MediaKeyStatusMap* keyStatuses();
 
     ScriptPromise generateRequest(ScriptState*, const String& initDataType, const DOMArrayPiece& initData);
     ScriptPromise load(ScriptState*, const String& sessionId);
 
     ScriptPromise update(ScriptState*, const DOMArrayPiece& response);
     ScriptPromise close(ScriptState*);
     ScriptPromise remove(ScriptState*);
 
     // EventTarget
     const AtomicString& interfaceName() const override;
     ExecutionContext* getExecutionContext() const override;
 
     // ActiveScriptWrappable
     bool hasPendingActivity() const final;
 
     // ActiveDOMObject
     void stop() override;
 
-    // Oilpan: eagerly release owned m_session, which in turn

[sof, 2016/04/11 06:23:32]

It is worth preserving these EAGERLY_FINALIZE() comments, could you move them
'down' next to the dispose() operation (throughout this CL.)

-    // drops the client reference back to this MediaKeySession object.
-    EAGERLY_FINALIZE();
     DECLARE_VIRTUAL_TRACE();
 
 private:
     class PendingAction;
     friend class NewSessionResultPromise;
     friend class LoadSessionResultPromise;
 
     MediaKeySession(ScriptState*, MediaKeys*, WebEncryptedMediaSessionType);
+    void dispose();
 
     void actionTimerFired(Timer<MediaKeySession>*);
 
     // WebContentDecryptionModuleSession::Client
     void message(MessageType, const unsigned char* message, size_t messageLength) override;
     void close() override;
     void expirationChanged(double updatedExpiryTimeInMS) override;
     void keysStatusesChange(const WebVector<WebEncryptedMediaKeyInformation>&, bool hasAdditionalUsableKey) override;
 
     // Called by NewSessionResult when the new session has been created.
@@ skipping 22 matching lines @@
     typedef ScriptPromiseProperty<Member<MediaKeySession>, ToV8UndefinedGenerator, Member<DOMException>> ClosedPromise;
     Member<ClosedPromise> m_closedPromise;
 
     HeapDeque<Member<PendingAction>> m_pendingActions;
     Timer<MediaKeySession> m_actionTimer;
 };
 
 } // namespace blink
 
 #endif // MediaKeySession_h