third_party/WebKit/Source/modules/encryptedmedia/MediaKeySession.h - Issue 1876703002: Oilpan: Replace EAGERLY_FINALIZE in EventTarget's hierarchy with pre-finalizers

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/encryptedmedia/MediaKeySession.h

Issue 1876703002: Oilpan: Replace EAGERLY_FINALIZE in EventTarget's hierarchy with pre-finalizers (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/events/EventTarget.h ('k') | third_party/WebKit/Source/modules/encryptedmedia/MediaKeySession.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/modules/encryptedmedia/MediaKeySession.h

diff --git a/third_party/WebKit/Source/modules/encryptedmedia/MediaKeySession.h b/third_party/WebKit/Source/modules/encryptedmedia/MediaKeySession.h

index 674729dea19bbbcaa475705ec8a8ad233fea48aa..491b9996019ee62212e8e1bd276c1b5c3603ff09 100644

--- a/third_party/WebKit/Source/modules/encryptedmedia/MediaKeySession.h

+++ b/third_party/WebKit/Source/modules/encryptedmedia/MediaKeySession.h

@@ -67,6 +67,7 @@ class MediaKeySession final

REFCOUNTED_GARBAGE_COLLECTED_EVENT_TARGET(MediaKeySession);

DEFINE_WRAPPERTYPEINFO();

USING_GARBAGE_COLLECTED_MIXIN(MediaKeySession);

+ USING_PRE_FINALIZER(MediaKeySession, dispose);

public:

static MediaKeySession* create(ScriptState*, MediaKeys*, WebEncryptedMediaSessionType);

~MediaKeySession() override;

@@ -93,9 +94,6 @@ public:

// ActiveDOMObject

void stop() override;

- // Oilpan: eagerly release owned m_session, which in turn

- // drops the client reference back to this MediaKeySession object.

- EAGERLY_FINALIZE();

DECLARE_VIRTUAL_TRACE();

private:

@@ -104,6 +102,7 @@ private:

friend class LoadSessionResultPromise;

MediaKeySession(ScriptState*, MediaKeys*, WebEncryptedMediaSessionType);

+ void dispose();

void actionTimerFired(Timer<MediaKeySession>*);