third_party/WebKit/Source/modules/mediasource/SourceBuffer.h - Issue 1876703002: Oilpan: Replace EAGERLY_FINALIZE in EventTarget's hierarchy with pre-finalizers

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/mediasource/SourceBuffer.h

Issue 1876703002: Oilpan: Replace EAGERLY_FINALIZE in EventTarget's hierarchy with pre-finalizers (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/modules/encryptedmedia/MediaKeySession.cpp ('k') | third_party/WebKit/Source/modules/mediasource/SourceBuffer.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/modules/mediasource/SourceBuffer.h

diff --git a/third_party/WebKit/Source/modules/mediasource/SourceBuffer.h b/third_party/WebKit/Source/modules/mediasource/SourceBuffer.h

index e2603ea8b14368a2a8cba890596273bfe5c798d0..3a7f3a9f695aaa890d37faa41c1043ae81d0928d 100644

--- a/third_party/WebKit/Source/modules/mediasource/SourceBuffer.h

+++ b/third_party/WebKit/Source/modules/mediasource/SourceBuffer.h

@@ -65,6 +65,7 @@ class SourceBuffer final

REFCOUNTED_GARBAGE_COLLECTED_EVENT_TARGET(SourceBuffer);

USING_GARBAGE_COLLECTED_MIXIN(SourceBuffer);

DEFINE_WRAPPERTYPEINFO();

+ USING_PRE_FINALIZER(SourceBuffer, dispose);

public:

static SourceBuffer* create(PassOwnPtr<WebSourceBuffer>, MediaSource*, GenericEventQueue*);

static const AtomicString& segmentsKeyword();

@@ -113,12 +114,11 @@ public:

// WebSourceBufferClient interface

std::vector<WebMediaPlayer::TrackId> initializationSegmentReceived(const std::vector<MediaTrackInfo>&) override;

- // Oilpan: eagerly release owned m_webSourceBuffer

- EAGERLY_FINALIZE();

DECLARE_VIRTUAL_TRACE();

private:

SourceBuffer(PassOwnPtr<WebSourceBuffer>, MediaSource*, GenericEventQueue*);

+ void dispose();

bool isRemoved() const;

void scheduleEvent(const AtomicString& eventName);