Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(835)

Unified Diff: third_party/WebKit/Source/core/events/EventTarget.h

Issue 1876703002: Oilpan: Replace EAGERLY_FINALIZE in EventTarget's hierarchy with pre-finalizers (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | third_party/WebKit/Source/modules/encryptedmedia/MediaKeySession.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/core/events/EventTarget.h
diff --git a/third_party/WebKit/Source/core/events/EventTarget.h b/third_party/WebKit/Source/core/events/EventTarget.h
index c5dfe998778d8bc5502d0c75bc8102f74c6c9d5a..7c701055c5f7f652501625819f21596eb45a5292 100644
--- a/third_party/WebKit/Source/core/events/EventTarget.h
+++ b/third_party/WebKit/Source/core/events/EventTarget.h
@@ -223,18 +223,9 @@ private:
template <typename T>
class RefCountedGarbageCollectedEventTargetWithInlineData : public EventTargetWithInlineData {
public:
- GC_PLUGIN_IGNORE("491488")
- void* operator new(size_t size)
- {
- // If T is eagerly finalized, it needs to be allocated accordingly.
- // Redefinition of the operator is needed to accomplish that, as otherwise
- // it would be allocated using GarbageCollected<EventTarget>'s operator new.
- // EventTarget is not eagerly finalized.
- return allocateObject(size, IsEagerlyFinalizedType<T>::value);
- }
-
DEFINE_INLINE_VIRTUAL_TRACE()
{
+ static_assert(!IsEagerlyFinalizedType<T>::value, "EventTargets do not support eager finalization.");
EventTargetWithInlineData::trace(visitor);
}
};
« no previous file with comments | « no previous file | third_party/WebKit/Source/modules/encryptedmedia/MediaKeySession.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698