third_party/WebKit/Source/modules/serviceworkers/ServiceWorkerRegistration.h - Issue 1876703002: Oilpan: Replace EAGERLY_FINALIZE in EventTarget's hierarchy with pre-finalizers

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/serviceworkers/ServiceWorkerRegistration.h

Issue 1876703002: Oilpan: Replace EAGERLY_FINALIZE in EventTarget's hierarchy with pre-finalizers (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/modules/mediastream/RTCPeerConnection.cpp ('k') | third_party/WebKit/Source/modules/serviceworkers/ServiceWorkerRegistration.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/modules/serviceworkers/ServiceWorkerRegistration.h

diff --git a/third_party/WebKit/Source/modules/serviceworkers/ServiceWorkerRegistration.h b/third_party/WebKit/Source/modules/serviceworkers/ServiceWorkerRegistration.h

index a9f546c5b555c7a920decd083d601b34ab8f7a90..43afd9d02b5b5c94278c7467a86b7eaa84cb02b6 100644

--- a/third_party/WebKit/Source/modules/serviceworkers/ServiceWorkerRegistration.h

+++ b/third_party/WebKit/Source/modules/serviceworkers/ServiceWorkerRegistration.h

@@ -37,6 +37,7 @@ class ServiceWorkerRegistration final

DEFINE_WRAPPERTYPEINFO();

REFCOUNTED_GARBAGE_COLLECTED_EVENT_TARGET(ServiceWorkerRegistration);

USING_GARBAGE_COLLECTED_MIXIN(ServiceWorkerRegistration);

+ USING_PRE_FINALIZER(ServiceWorkerRegistration, dispose);

public:

// EventTarget overrides.

const AtomicString& interfaceName() const override;

@@ -67,12 +68,11 @@ public:

~ServiceWorkerRegistration() override;

- // Eager finalization needed to promptly release owned WebServiceWorkerRegistration.

- EAGERLY_FINALIZE();

DECLARE_VIRTUAL_TRACE();

private:

ServiceWorkerRegistration(ExecutionContext*, PassOwnPtr<WebServiceWorkerRegistration::Handle>);

+ void dispose();

// ActiveScriptWrappable overrides.

bool hasPendingActivity() const final;