third_party/WebKit/Source/modules/mediastream/RTCDataChannel.cpp - Issue 1876703002: Oilpan: Replace EAGERLY_FINALIZE in EventTarget's hierarchy with pre-finalizers

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/mediastream/RTCDataChannel.cpp

Issue 1876703002: Oilpan: Replace EAGERLY_FINALIZE in EventTarget's hierarchy with pre-finalizers (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/modules/mediastream/RTCDataChannel.h ('k') | third_party/WebKit/Source/modules/mediastream/RTCPeerConnection.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/modules/mediastream/RTCDataChannel.cpp

diff --git a/third_party/WebKit/Source/modules/mediastream/RTCDataChannel.cpp b/third_party/WebKit/Source/modules/mediastream/RTCDataChannel.cpp

index e0101c9769e82c8047a95be27f8f2ad0e9bba938..b3436128d240ee773e1b44cb97d491be7122233d 100644

--- a/third_party/WebKit/Source/modules/mediastream/RTCDataChannel.cpp

+++ b/third_party/WebKit/Source/modules/mediastream/RTCDataChannel.cpp

@@ -75,13 +75,20 @@ RTCDataChannel::RTCDataChannel(ExecutionContext* context, PassOwnPtr<WebRTCDataC

, m_scheduledEventTimer(this, &RTCDataChannel::scheduledEventTimerFired)

, m_bufferedAmountLowThreshold(0U)

{

+ ThreadState::current()->registerPreFinalizer(this);

m_handler->setClient(this);

}

RTCDataChannel::~RTCDataChannel()

{

- // Notify the client that the channel is gone.

- m_handler->setClient(0);

+void RTCDataChannel::dispose()

+ // Promptly clears a raw reference from content/ to an on-heap object

+ // so that content/ doesn't access it in a lazy sweeping phase.

+ m_handler->setClient(nullptr);

+ m_handler.clear();

}

RTCDataChannel::ReadyState RTCDataChannel::getHandlerState() const