Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(592)

Unified Diff: third_party/WebKit/Source/modules/mediastream/RTCDataChannel.h

Issue 1876703002: Oilpan: Replace EAGERLY_FINALIZE in EventTarget's hierarchy with pre-finalizers (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/modules/mediastream/RTCDataChannel.h
diff --git a/third_party/WebKit/Source/modules/mediastream/RTCDataChannel.h b/third_party/WebKit/Source/modules/mediastream/RTCDataChannel.h
index cd808414fc329355a30f8deeb03faedb863ad3fc..a787a9da40b454544242fabd393a7461330cd3ad 100644
--- a/third_party/WebKit/Source/modules/mediastream/RTCDataChannel.h
+++ b/third_party/WebKit/Source/modules/mediastream/RTCDataChannel.h
@@ -49,6 +49,7 @@ class MODULES_EXPORT RTCDataChannel final
, WTF_NON_EXPORTED_BASE(public WebRTCDataChannelHandlerClient) {
REFCOUNTED_GARBAGE_COLLECTED_EVENT_TARGET(RTCDataChannel);
DEFINE_WRAPPERTYPEINFO();
+ USING_PRE_FINALIZER(RTCDataChannel, dispose);
public:
static RTCDataChannel* create(ExecutionContext*, PassOwnPtr<WebRTCDataChannelHandler>);
static RTCDataChannel* create(ExecutionContext*, WebRTCPeerConnectionHandler*, const String& label, const WebRTCDataChannelInit&, ExceptionState&);
@@ -93,8 +94,6 @@ public:
const AtomicString& interfaceName() const override;
ExecutionContext* getExecutionContext() const override;
- // Oilpan: need to eagerly finalize m_handler
- EAGERLY_FINALIZE();
DECLARE_VIRTUAL_TRACE();
// WebRTCDataChannelHandlerClient
@@ -106,6 +105,7 @@ public:
private:
RTCDataChannel(ExecutionContext*, PassOwnPtr<WebRTCDataChannelHandler>);
+ void dispose();
void scheduleDispatchEvent(Event*);
void scheduledEventTimerFired(Timer<RTCDataChannel>*);

Powered by Google App Engine
This is Rietveld 408576698