third_party/WebKit/Source/modules/mediastream/RTCPeerConnection.h - Issue 1876703002: Oilpan: Replace EAGERLY_FINALIZE in EventTarget's hierarchy with pre-finalizers

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/mediastream/RTCPeerConnection.h

Issue 1876703002: Oilpan: Replace EAGERLY_FINALIZE in EventTarget's hierarchy with pre-finalizers (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/modules/mediastream/RTCDataChannel.cpp ('k') | third_party/WebKit/Source/modules/mediastream/RTCPeerConnection.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/modules/mediastream/RTCPeerConnection.h

diff --git a/third_party/WebKit/Source/modules/mediastream/RTCPeerConnection.h b/third_party/WebKit/Source/modules/mediastream/RTCPeerConnection.h

index a66607625c80cc93224f2b14ddef27b5ea09a99b..2ce03d694d91ab7c6ef629fb63796dedc515a310 100644

--- a/third_party/WebKit/Source/modules/mediastream/RTCPeerConnection.h

+++ b/third_party/WebKit/Source/modules/mediastream/RTCPeerConnection.h

@@ -69,6 +69,7 @@ class RTCPeerConnection final

REFCOUNTED_GARBAGE_COLLECTED_EVENT_TARGET(RTCPeerConnection);

DEFINE_WRAPPERTYPEINFO();

USING_GARBAGE_COLLECTED_MIXIN(RTCPeerConnection);

+ USING_PRE_FINALIZER(RTCPeerConnection, dispose);

public:

// TODO(hbos): Create with expired RTCCertificate should fail, see crbug.com/565278.

static RTCPeerConnection* create(ExecutionContext*, const Dictionary&, const Dictionary&, ExceptionState&);

@@ -161,8 +162,6 @@ public:

return !m_closed && !m_stopped;

}

- // Oilpan: need to eagerly finalize m_peerHandler

- EAGERLY_FINALIZE();

DECLARE_VIRTUAL_TRACE();

private:

@@ -183,6 +182,7 @@ private:

};

RTCPeerConnection(ExecutionContext*, RTCConfiguration*, WebMediaConstraints, ExceptionState&);

+ void dispose();

void scheduleDispatchEvent(Event*);

void scheduleDispatchEvent(Event*, PassOwnPtr<BoolFunction>);