third_party/WebKit/Source/modules/webusb/USB.h - Issue 1876703002: Oilpan: Replace EAGERLY_FINALIZE in EventTarget's hierarchy with pre-finalizers

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/webusb/USB.h

Issue 1876703002: Oilpan: Replace EAGERLY_FINALIZE in EventTarget's hierarchy with pre-finalizers (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: third_party/WebKit/Source/modules/webusb/USB.h

diff --git a/third_party/WebKit/Source/modules/webusb/USB.h b/third_party/WebKit/Source/modules/webusb/USB.h

index 026fe8008d5b3f3f9cf19af372a24c2aa166f64c..e5708dd494925cf2f98044d68e3d8aefe546fd81 100644

--- a/third_party/WebKit/Source/modules/webusb/USB.h

+++ b/third_party/WebKit/Source/modules/webusb/USB.h

@@ -26,6 +26,7 @@ class USB final

DEFINE_WRAPPERTYPEINFO();

REFCOUNTED_GARBAGE_COLLECTED_EVENT_TARGET(USB);

USING_GARBAGE_COLLECTED_MIXIN(USB);

+ USING_PRE_FINALIZER(USB, dispose);

public:

static USB* create(LocalFrame& frame)

{

@@ -52,10 +53,10 @@ public:

void onDeviceDisconnected(std::unique_ptr<WebUSBDevice>) override;

DECLARE_VIRTUAL_TRACE();

- EAGERLY_FINALIZE();

private:

explicit USB(LocalFrame& frame);

+ void dispose();

WebUSBClient* m_client;

};

« no previous file with comments | « third_party/WebKit/Source/modules/webmidi/MIDIAccess.cpp ('k') | third_party/WebKit/Source/modules/webusb/USB.cpp » ('j') | no next file with comments »