chrome/browser/chromeos/boot_times_recorder.cc - Issue 1870793002: Convert //chrome/browser/chromeos from scoped_ptr to std::unique_ptr

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/chromeos/boot_times_recorder.cc

Issue 1870793002: Convert //chrome/browser/chromeos from scoped_ptr to std::unique_ptr (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: rebase Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/chromeos/base/locale_util.cc ('k') | chrome/browser/chromeos/certificate_provider/certificate_provider.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/chromeos/boot_times_recorder.cc

diff --git a/chrome/browser/chromeos/boot_times_recorder.cc b/chrome/browser/chromeos/boot_times_recorder.cc

index 168a9b3a520ec4ea7cc1c42591b6b99dc531c92c..8611fdceb74108e898c89bd8a9b8d9bba5da6409 100644

--- a/chrome/browser/chromeos/boot_times_recorder.cc

+++ b/chrome/browser/chromeos/boot_times_recorder.cc

@@ -174,7 +174,7 @@ BootTimesRecorder::Stats BootTimesRecorder::Stats::DeserializeFromString(

if (source.empty())

return Stats();

- scoped_ptr<base::Value> value = base::JSONReader::Read(source);

+ std::unique_ptr<base::Value> value = base::JSONReader::Read(source);

base::DictionaryValue* dictionary;

if (!value || !value->GetAsDictionary(&dictionary)) {

LOG(ERROR) << "BootTimesRecorder::Stats::DeserializeFromString(): not a "

« no previous file with comments | « chrome/browser/chromeos/base/locale_util.cc ('k') | chrome/browser/chromeos/certificate_provider/certificate_provider.h » ('j') | no next file with comments »