chrome/browser/chromeos/first_run/drive_first_run_controller.cc - Issue 1870793002: Convert //chrome/browser/chromeos from scoped_ptr to std::unique_ptr

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/chromeos/first_run/drive_first_run_controller.cc

Issue 1870793002: Convert //chrome/browser/chromeos from scoped_ptr to std::unique_ptr (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: rebase Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/chromeos/first_run/drive_first_run_controller.h ('k') | chrome/browser/chromeos/first_run/first_run_controller.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/chromeos/first_run/drive_first_run_controller.cc

diff --git a/chrome/browser/chromeos/first_run/drive_first_run_controller.cc b/chrome/browser/chromeos/first_run/drive_first_run_controller.cc

index 72f85595c3a5f2afd7e42a6b7a57672cbccb73f8..9d1cbf5e1ff9c07e509c4ed4d2e53b0c38a0dc54 100644

--- a/chrome/browser/chromeos/first_run/drive_first_run_controller.cc

+++ b/chrome/browser/chromeos/first_run/drive_first_run_controller.cc

@@ -180,7 +180,7 @@ class DriveWebContentsManager : public content::WebContentsObserver,

Profile* profile_;

const std::string app_id_;

const std::string endpoint_url_;

- scoped_ptr<content::WebContents> web_contents_;

+ std::unique_ptr<content::WebContents> web_contents_;

content::NotificationRegistrar registrar_;

bool started_;

CompletionCallback completion_callback_;

@@ -459,7 +459,7 @@ void DriveFirstRunController::ShowNotification() {

data.buttons.push_back(message_center::ButtonInfo(

l10n_util::GetStringUTF16(IDS_DRIVE_OFFLINE_NOTIFICATION_BUTTON)));

ui::ResourceBundle& resource_bundle = ui::ResourceBundle::GetSharedInstance();

- scoped_ptr<message_center::Notification> notification(

+ std::unique_ptr<message_center::Notification> notification(

new message_center::Notification(

message_center::NOTIFICATION_TYPE_SIMPLE, kDriveOfflineNotificationId,

base::string16(), // title