chrome/browser/chromeos/file_system_provider/operations/read_file.h - Issue 1870793002: Convert //chrome/browser/chromeos from scoped_ptr to std::unique_ptr

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/chromeos/file_system_provider/operations/read_file.h

Issue 1870793002: Convert //chrome/browser/chromeos from scoped_ptr to std::unique_ptr (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: rebase Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/chromeos/file_system_provider/operations/read_directory_unittest.cc ('k') | chrome/browser/chromeos/file_system_provider/operations/read_file.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/chromeos/file_system_provider/operations/read_file.h

diff --git a/chrome/browser/chromeos/file_system_provider/operations/read_file.h b/chrome/browser/chromeos/file_system_provider/operations/read_file.h

index 6f8b43429c29dd36813adcba5978f8e0a8f3e09e..dc40e8019c009a4d5231d33a420c603957d22c1a 100644

--- a/chrome/browser/chromeos/file_system_provider/operations/read_file.h

+++ b/chrome/browser/chromeos/file_system_provider/operations/read_file.h

@@ -7,10 +7,11 @@

#include <stdint.h>

+#include <memory>

#include "base/files/file.h"

#include "base/macros.h"

#include "base/memory/ref_counted.h"

-#include "base/memory/scoped_ptr.h"

#include "chrome/browser/chromeos/file_system_provider/operations/operation.h"

#include "chrome/browser/chromeos/file_system_provider/provided_file_system_info.h"

#include "chrome/browser/chromeos/file_system_provider/provided_file_system_interface.h"

@@ -47,10 +48,10 @@ class ReadFile : public Operation {

// Operation overrides.

bool Execute(int request_id) override;

void OnSuccess(int request_id,

- scoped_ptr<RequestValue> result,

+ std::unique_ptr<RequestValue> result,

bool has_more) override;

void OnError(int request_id,

- scoped_ptr<RequestValue> result,

+ std::unique_ptr<RequestValue> result,

base::File::Error error) override;

private: