chrome/browser/chromeos/net/network_portal_detector_test_utils.cc - Issue 1870793002: Convert //chrome/browser/chromeos from scoped_ptr to std::unique_ptr

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/chromeos/net/network_portal_detector_test_utils.cc

Issue 1870793002: Convert //chrome/browser/chromeos from scoped_ptr to std::unique_ptr (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: rebase Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/chromeos/net/network_portal_detector_test_impl.h ('k') | chrome/browser/chromeos/net/network_portal_notification_controller.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/chromeos/net/network_portal_detector_test_utils.cc

diff --git a/chrome/browser/chromeos/net/network_portal_detector_test_utils.cc b/chrome/browser/chromeos/net/network_portal_detector_test_utils.cc

index c5d9adb4a738d519437fd150ac275ea19edb402c..38cf86449e881050486f84809ada4a317b84a8d7 100644

--- a/chrome/browser/chromeos/net/network_portal_detector_test_utils.cc

+++ b/chrome/browser/chromeos/net/network_portal_detector_test_utils.cc

@@ -7,9 +7,9 @@

#include <stddef.h>

#include <algorithm>

+#include <memory>

#include "base/logging.h"

-#include "base/memory/scoped_ptr.h"

#include "base/metrics/histogram_base.h"

#include "base/metrics/histogram_samples.h"

#include "base/metrics/statistics_recorder.h"

@@ -44,7 +44,8 @@ bool EnumHistogramChecker::Check() {

}

return true;

}

- scoped_ptr<base::HistogramSamples> samples = histogram->SnapshotSamples();

+ std::unique_ptr<base::HistogramSamples> samples =

+ histogram->SnapshotSamples();

if (!samples.get()) {

if (!empty) {

LOG(ERROR) << "Non-empty expectations for " << histogram_ << " "