chrome/browser/chromeos/system_logs/lsb_release_log_source.cc - Issue 1870793002: Convert //chrome/browser/chromeos from scoped_ptr to std::unique_ptr

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/chromeos/system_logs/lsb_release_log_source.cc

Issue 1870793002: Convert //chrome/browser/chromeos from scoped_ptr to std::unique_ptr (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: rebase Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/chromeos/system_logs/device_event_log_source.cc ('k') | chrome/browser/chromeos/system_logs/touch_log_source_ozone.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/chromeos/system_logs/lsb_release_log_source.cc

diff --git a/chrome/browser/chromeos/system_logs/lsb_release_log_source.cc b/chrome/browser/chromeos/system_logs/lsb_release_log_source.cc

index 833afb0a0238fd69b9d0c5cd55035e8b6f578abc..5dfb1fe42314237f7c54fd8a0962fa312ea02ce5 100644

--- a/chrome/browser/chromeos/system_logs/lsb_release_log_source.cc

+++ b/chrome/browser/chromeos/system_logs/lsb_release_log_source.cc

@@ -4,7 +4,8 @@

#include "chrome/browser/chromeos/system_logs/lsb_release_log_source.h"

-#include "base/memory/scoped_ptr.h"

+#include <memory>

#include "base/sys_info.h"

namespace system_logs {

@@ -17,7 +18,7 @@ LsbReleaseLogSource::~LsbReleaseLogSource() {

void LsbReleaseLogSource::Fetch(const SysLogsSourceCallback& callback) {

DCHECK(!callback.is_null());

- scoped_ptr<SystemLogsResponse> response(new SystemLogsResponse);

+ std::unique_ptr<SystemLogsResponse> response(new SystemLogsResponse);

const base::SysInfo::LsbReleaseMap& lsb_map =

base::SysInfo::GetLsbReleaseMap();

for (base::SysInfo::LsbReleaseMap::const_iterator iter = lsb_map.begin();