Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(193)

Side by Side Diff: chrome/browser/chromeos/login/error_screens_histogram_helper_unittest.cc

Issue 1870793002: Convert //chrome/browser/chromeos from scoped_ptr to std::unique_ptr (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: rebase Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/chromeos/login/error_screens_histogram_helper.h" 5 #include "chrome/browser/chromeos/login/error_screens_histogram_helper.h"
6 6
7 #include "base/metrics/statistics_recorder.h" 7 #include "base/metrics/statistics_recorder.h"
8 #include "base/test/histogram_tester.h" 8 #include "base/test/histogram_tester.h"
9 #include "chrome/browser/chromeos/login/screens/network_error.h" 9 #include "chrome/browser/chromeos/login/screens/network_error.h"
10 #include "content/public/test/test_browser_thread_bundle.h" 10 #include "content/public/test/test_browser_thread_bundle.h"
11 #include "testing/gtest/include/gtest/gtest.h" 11 #include "testing/gtest/include/gtest/gtest.h"
12 12
13 namespace chromeos { 13 namespace chromeos {
14 14
15 class ErrorScreensHistogramHelperTest : public testing::Test { 15 class ErrorScreensHistogramHelperTest : public testing::Test {
16 public: 16 public:
17 void SetUp() override { 17 void SetUp() override {
18 helper_.reset(new ErrorScreensHistogramHelper("TestScreen")); 18 helper_.reset(new ErrorScreensHistogramHelper("TestScreen"));
19 second_helper_.reset(new ErrorScreensHistogramHelper("TestScreen2")); 19 second_helper_.reset(new ErrorScreensHistogramHelper("TestScreen2"));
20 } 20 }
21 21
22 content::TestBrowserThreadBundle thread_bundle_; 22 content::TestBrowserThreadBundle thread_bundle_;
23 base::HistogramTester histograms_; 23 base::HistogramTester histograms_;
24 scoped_ptr<ErrorScreensHistogramHelper> helper_; 24 std::unique_ptr<ErrorScreensHistogramHelper> helper_;
25 scoped_ptr<ErrorScreensHistogramHelper> second_helper_; 25 std::unique_ptr<ErrorScreensHistogramHelper> second_helper_;
26 }; 26 };
27 27
28 // No errors when screen was not shown. 28 // No errors when screen was not shown.
29 TEST_F(ErrorScreensHistogramHelperTest, DoesNotShowScreen) { 29 TEST_F(ErrorScreensHistogramHelperTest, DoesNotShowScreen) {
30 helper_.reset(); 30 helper_.reset();
31 histograms_.ExpectTotalCount("OOBE.NetworkErrorShown.TestScreen", 0); 31 histograms_.ExpectTotalCount("OOBE.NetworkErrorShown.TestScreen", 0);
32 } 32 }
33 33
34 // No errors when screen was shown and error was not. 34 // No errors when screen was shown and error was not.
35 TEST_F(ErrorScreensHistogramHelperTest, ShowScreenWithoutError) { 35 TEST_F(ErrorScreensHistogramHelperTest, ShowScreenWithoutError) {
(...skipping 71 matching lines...) Expand 10 before | Expand all | Expand 10 after
107 now += base::TimeDelta::FromMilliseconds(1000); 107 now += base::TimeDelta::FromMilliseconds(1000);
108 helper_->OnErrorShowTime(NetworkError::ERROR_STATE_PORTAL, now); 108 helper_->OnErrorShowTime(NetworkError::ERROR_STATE_PORTAL, now);
109 now += base::TimeDelta::FromMilliseconds(1000); 109 now += base::TimeDelta::FromMilliseconds(1000);
110 helper_->OnErrorHideTime(now); 110 helper_->OnErrorHideTime(now);
111 helper_.reset(); 111 helper_.reset();
112 histograms_.ExpectUniqueSample( 112 histograms_.ExpectUniqueSample(
113 "OOBE.ErrorScreensTime.TestScreen.Portal", 2000, 1); 113 "OOBE.ErrorScreensTime.TestScreen.Portal", 2000, 1);
114 } 114 }
115 115
116 } // namespace chromeos 116 } // namespace chromeos
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698