chrome/browser/chromeos/login/test/app_window_waiter.h - Issue 1870793002: Convert //chrome/browser/chromeos from scoped_ptr to std::unique_ptr

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/chromeos/login/test/app_window_waiter.h

Issue 1870793002: Convert //chrome/browser/chromeos from scoped_ptr to std::unique_ptr (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: rebase Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/chromeos/login/supervised/supervised_user_test_base.cc ('k') | chrome/browser/chromeos/login/test/https_forwarder.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/chromeos/login/test/app_window_waiter.h

diff --git a/chrome/browser/chromeos/login/test/app_window_waiter.h b/chrome/browser/chromeos/login/test/app_window_waiter.h

index 90db4ddc2c7a4b387e5050eee71e54e5f18cca24..043c813d9264c53aba5f0197021b7126290e18af 100644

--- a/chrome/browser/chromeos/login/test/app_window_waiter.h

+++ b/chrome/browser/chromeos/login/test/app_window_waiter.h

@@ -5,11 +5,11 @@

#ifndef CHROME_BROWSER_CHROMEOS_LOGIN_TEST_APP_WINDOW_WAITER_H_

#define CHROME_BROWSER_CHROMEOS_LOGIN_TEST_APP_WINDOW_WAITER_H_

+#include <memory>

#include <string>

#include "base/compiler_specific.h"

#include "base/macros.h"

-#include "base/memory/scoped_ptr.h"

#include "base/run_loop.h"

#include "extensions/browser/app_window/app_window_registry.h"

@@ -47,7 +47,7 @@ class AppWindowWaiter : public extensions::AppWindowRegistry::Observer {

extensions::AppWindowRegistry* const registry_;

const std::string app_id_;

- scoped_ptr<base::RunLoop> run_loop_;

+ std::unique_ptr<base::RunLoop> run_loop_;

WaitType wait_type_ = WAIT_FOR_NONE;

extensions::AppWindow* window_ = nullptr;