chrome/browser/chromeos/extensions/echo_private_api.cc - Issue 1870793002: Convert //chrome/browser/chromeos from scoped_ptr to std::unique_ptr

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/chromeos/extensions/echo_private_api.cc

Issue 1870793002: Convert //chrome/browser/chromeos from scoped_ptr to std::unique_ptr (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: rebase Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/chromeos/extensions/dictionary_event_router.cc ('k') | chrome/browser/chromeos/extensions/echo_private_apitest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/chromeos/extensions/echo_private_api.cc

diff --git a/chrome/browser/chromeos/extensions/echo_private_api.cc b/chrome/browser/chromeos/extensions/echo_private_api.cc

index 93e0babb24f6ffeac8868974efcc7c91e3d52fa1..728b77a974bdfa94f5e72c1996e365467075b3c0 100644

--- a/chrome/browser/chromeos/extensions/echo_private_api.cc

+++ b/chrome/browser/chromeos/extensions/echo_private_api.cc

@@ -82,7 +82,7 @@ void EchoPrivateGetRegistrationCodeFunction::GetRegistrationCode(

}

bool EchoPrivateGetRegistrationCodeFunction::RunSync() {

- scoped_ptr<echo_api::GetRegistrationCode::Params> params =

+ std::unique_ptr<echo_api::GetRegistrationCode::Params> params =

echo_api::GetRegistrationCode::Params::Create(*args_);

EXTENSION_FUNCTION_VALIDATE(params);

GetRegistrationCode(params->type);

@@ -94,12 +94,12 @@ EchoPrivateSetOfferInfoFunction::EchoPrivateSetOfferInfoFunction() {}

EchoPrivateSetOfferInfoFunction::~EchoPrivateSetOfferInfoFunction() {}

bool EchoPrivateSetOfferInfoFunction::RunSync() {

- scoped_ptr<echo_api::SetOfferInfo::Params> params =

+ std::unique_ptr<echo_api::SetOfferInfo::Params> params =

echo_api::SetOfferInfo::Params::Create(*args_);

EXTENSION_FUNCTION_VALIDATE(params);

const std::string& service_id = params->id;

- scoped_ptr<base::DictionaryValue> dict =

+ std::unique_ptr<base::DictionaryValue> dict =

params->offer_info.additional_properties.DeepCopyWithoutEmptyChildren();

PrefService* local_state = g_browser_process->local_state();

@@ -113,7 +113,7 @@ EchoPrivateGetOfferInfoFunction::EchoPrivateGetOfferInfoFunction() {}

EchoPrivateGetOfferInfoFunction::~EchoPrivateGetOfferInfoFunction() {}

bool EchoPrivateGetOfferInfoFunction::RunSync() {

- scoped_ptr<echo_api::GetOfferInfo::Params> params =

+ std::unique_ptr<echo_api::GetOfferInfo::Params> params =

echo_api::GetOfferInfo::Params::Create(*args_);

EXTENSION_FUNCTION_VALIDATE(params);

@@ -231,7 +231,7 @@ void EchoPrivateGetUserConsentFunction::OnRedeemOffersAllowedChecked(

bool is_allowed) {

redeem_offers_allowed_ = is_allowed;

- scoped_ptr<echo_api::GetUserConsent::Params> params =

+ std::unique_ptr<echo_api::GetUserConsent::Params> params =

echo_api::GetUserConsent::Params::Create(*args_);

// Verify that the passed origin URL is valid.