chrome/browser/chromeos/file_manager/file_tasks_unittest.cc - Issue 1870793002: Convert //chrome/browser/chromeos from scoped_ptr to std::unique_ptr

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/chromeos/file_manager/file_tasks_unittest.cc

Issue 1870793002: Convert //chrome/browser/chromeos from scoped_ptr to std::unique_ptr (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: rebase Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/chromeos/file_manager/file_manager_browsertest_base.cc ('k') | chrome/browser/chromeos/file_manager/file_watcher.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/chromeos/file_manager/file_tasks_unittest.cc

diff --git a/chrome/browser/chromeos/file_manager/file_tasks_unittest.cc b/chrome/browser/chromeos/file_manager/file_tasks_unittest.cc

index 0bfc3330f9ee271375b16fa65065fb40e05a2217..66a266cafd15b02af6e32e60bb758adddf5dfad8 100644

--- a/chrome/browser/chromeos/file_manager/file_tasks_unittest.cc

+++ b/chrome/browser/chromeos/file_manager/file_tasks_unittest.cc

@@ -173,7 +173,8 @@ TEST(FileManagerFileTasksTest, FindDriveAppTasks) {

content::TestBrowserThreadBundle thread_bundle;

// Foo.app can handle "text/plain" and "text/html"

- scoped_ptr<google_apis::AppResource> foo_app(new google_apis::AppResource);

+ std::unique_ptr<google_apis::AppResource> foo_app(

+ new google_apis::AppResource);

foo_app->set_product_id("foo_app_id");

foo_app->set_application_id("foo_app_id");

foo_app->set_name("Foo");

@@ -184,7 +185,8 @@ TEST(FileManagerFileTasksTest, FindDriveAppTasks) {

foo_app->set_primary_mimetypes(std::move(foo_mime_types));

// Bar.app can only handle "text/plain".

- scoped_ptr<google_apis::AppResource> bar_app(new google_apis::AppResource);

+ std::unique_ptr<google_apis::AppResource> bar_app(

+ new google_apis::AppResource);

bar_app->set_product_id("bar_app_id");

bar_app->set_application_id("bar_app_id");

bar_app->set_name("Bar");

@@ -706,7 +708,8 @@ TEST_F(FileManagerFileTasksComplexTest, FindAllTypesOfTasks) {

// Baz.app can handle "text/plain".

// This is a Drive app.

- scoped_ptr<google_apis::AppResource> baz_app(new google_apis::AppResource);

+ std::unique_ptr<google_apis::AppResource> baz_app(

+ new google_apis::AppResource);

baz_app->set_product_id("baz_app_id");

baz_app->set_application_id(kBazId);

baz_app->set_name("Baz");

@@ -754,7 +757,8 @@ TEST_F(FileManagerFileTasksComplexTest, FindAllTypesOfTasks_GoogleDocument) {

const char kBarId[] = "odlhccgofgkadkkhcmhgnhgahonahoca";

// Foo.app can handle ".gdoc" files.

- scoped_ptr<google_apis::AppResource> foo_app(new google_apis::AppResource);

+ std::unique_ptr<google_apis::AppResource> foo_app(

+ new google_apis::AppResource);

foo_app->set_product_id("foo_app");

foo_app->set_application_id(kFooId);

foo_app->set_name("Foo");