- Refactor Symbol allocation to expect a thread parameter.

- Refactor Symbol allocation to expect a thread parameter.
- Preallocate all tokens as symbols to avoid repeated lookups.
- Pass thread/zone where useful while doing this change.
- Avoid allocating symbols for error messages.

BUG=
R=fschneider@google.com

Committed: https://github.com/dart-lang/sdk/commit/5be5d54529d1f6b2c23dd2adaceb964a7d1fbcb7

[Ivan Posva, 2016-04-09 01:27:25]

iposva@google.com changed reviewers:
+ fschneider@google.com

[Florian Schneider, 2016-04-11 22:07:22]

lgtm

https://codereview.chromium.org/1870343002/diff/1/runtime/vm/symbols.cc
File runtime/vm/symbols.cc (right):

https://codereview.chromium.org/1870343002/diff/1/runtime/vm/symbols.cc#newco...
runtime/vm/symbols.cc:681: const char* format, va_list args) {
Formatting: One argument per line

[Ivan Posva, 2016-04-11 23:28:33]

Description was changed from

==========
- Refactor Symbol allocation to expect a thread parameter.
- Preallocate all tokens as symbols to avoid repeated lookups.
- Pass thread/zone where useful while doing this change.
- Avoid allocating symbols for error messages.

BUG=
==========

to

==========
- Refactor Symbol allocation to expect a thread parameter.
- Preallocate all tokens as symbols to avoid repeated lookups.
- Pass thread/zone where useful while doing this change.
- Avoid allocating symbols for error messages.

BUG=
R=fschneider@google.com

Committed:
https://github.com/dart-lang/sdk/commit/5be5d54529d1f6b2c23dd2adaceb964a7d1fbcb7
==========

[Ivan Posva, 2016-04-11 23:28:35]

Committed patchset #2 (id:20001) manually as
5be5d54529d1f6b2c23dd2adaceb964a7d1fbcb7 (presubmit successful).

[Ivan Posva, 2016-04-11 23:29:33]

Thanks! -ip

https://codereview.chromium.org/1870343002/diff/1/runtime/vm/symbols.cc
File runtime/vm/symbols.cc (right):

https://codereview.chromium.org/1870343002/diff/1/runtime/vm/symbols.cc#newco...
runtime/vm/symbols.cc:681: const char* format, va_list args) {
On 2016/04/11 22:07:22, Florian Schneider wrote:
> Formatting: One argument per line

Done.