Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(28)

Side by Side Diff: runtime/vm/service_test.cc

Issue 1870343002: - Refactor Symbol allocation to expect a thread parameter. (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: Address review feedback. Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « runtime/vm/scopes_test.cc ('k') | runtime/vm/snapshot_test.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2013, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2013, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 #include "platform/globals.h" 5 #include "platform/globals.h"
6 6
7 #include "include/dart_tools_api.h" 7 #include "include/dart_tools_api.h"
8 #include "vm/dart_api_impl.h" 8 #include "vm/dart_api_impl.h"
9 #include "vm/dart_entry.h" 9 #include "vm/dart_entry.h"
10 #include "vm/debugger.h" 10 #include "vm/debugger.h"
(...skipping 91 matching lines...) Expand 10 before | Expand all | Expand 10 after
102 static RawFunction* GetFunction(const Class& cls, const char* name) { 102 static RawFunction* GetFunction(const Class& cls, const char* name) {
103 const Function& result = Function::Handle(cls.LookupDynamicFunction( 103 const Function& result = Function::Handle(cls.LookupDynamicFunction(
104 String::Handle(String::New(name)))); 104 String::Handle(String::New(name))));
105 EXPECT(!result.IsNull()); 105 EXPECT(!result.IsNull());
106 return result.raw(); 106 return result.raw();
107 } 107 }
108 108
109 109
110 static RawClass* GetClass(const Library& lib, const char* name) { 110 static RawClass* GetClass(const Library& lib, const char* name) {
111 const Class& cls = Class::Handle( 111 const Class& cls = Class::Handle(
112 lib.LookupClass(String::Handle(Symbols::New(name)))); 112 lib.LookupClass(String::Handle(Symbols::New(Thread::Current(), name))));
113 EXPECT(!cls.IsNull()); // No ambiguity error expected. 113 EXPECT(!cls.IsNull()); // No ambiguity error expected.
114 return cls.raw(); 114 return cls.raw();
115 } 115 }
116 116
117 117
118 TEST_CASE(Service_IdZones) { 118 TEST_CASE(Service_IdZones) {
119 Zone* zone = thread->zone(); 119 Zone* zone = thread->zone();
120 Isolate* isolate = thread->isolate(); 120 Isolate* isolate = thread->isolate();
121 ObjectIdRing* ring = isolate->object_id_ring(); 121 ObjectIdRing* ring = isolate->object_id_ring();
122 122
(...skipping 594 matching lines...) Expand 10 before | Expand all | Expand 10 after
717 EXPECT_EQ(MessageHandler::kOK, handler.HandleNextMessage()); 717 EXPECT_EQ(MessageHandler::kOK, handler.HandleNextMessage());
718 // Expect error. 718 // Expect error.
719 EXPECT_SUBSTRING("\"error\"", handler.msg()); 719 EXPECT_SUBSTRING("\"error\"", handler.msg());
720 } 720 }
721 721
722 #endif // !defined(TARGET_ARCH_ARM64) 722 #endif // !defined(TARGET_ARCH_ARM64)
723 723
724 #endif // !PRODUCT 724 #endif // !PRODUCT
725 725
726 } // namespace dart 726 } // namespace dart
OLDNEW
« no previous file with comments | « runtime/vm/scopes_test.cc ('k') | runtime/vm/snapshot_test.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698