Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(199)

Side by Side Diff: runtime/vm/code_patcher_arm64_test.cc

Issue 1870343002: - Refactor Symbol allocation to expect a thread parameter. (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: Address review feedback. Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « runtime/vm/code_generator_test.cc ('k') | runtime/vm/code_patcher_arm_test.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2014, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2014, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 #include "vm/globals.h" 5 #include "vm/globals.h"
6 #if defined(TARGET_ARCH_ARM64) 6 #if defined(TARGET_ARCH_ARM64)
7 7
8 #include "vm/assembler.h" 8 #include "vm/assembler.h"
9 #include "vm/code_generator.h" 9 #include "vm/code_generator.h"
10 #include "vm/code_patcher.h" 10 #include "vm/code_patcher.h"
11 #include "vm/dart_entry.h" 11 #include "vm/dart_entry.h"
12 #include "vm/instructions.h" 12 #include "vm/instructions.h"
13 #include "vm/native_entry.h" 13 #include "vm/native_entry.h"
14 #include "vm/native_entry_test.h" 14 #include "vm/native_entry_test.h"
15 #include "vm/stub_code.h" 15 #include "vm/stub_code.h"
16 #include "vm/symbols.h" 16 #include "vm/symbols.h"
17 #include "vm/unit_test.h" 17 #include "vm/unit_test.h"
18 18
19 namespace dart { 19 namespace dart {
20 20
21 #define __ assembler-> 21 #define __ assembler->
22 22
23 ASSEMBLER_TEST_GENERATE(IcDataAccess, assembler) { 23 ASSEMBLER_TEST_GENERATE(IcDataAccess, assembler) {
24 const String& class_name = String::Handle(Symbols::New("ownerClass")); 24 Thread* thread = Thread::Current();
25 const String& class_name = String::Handle(Symbols::New(thread, "ownerClass"));
25 const Script& script = Script::Handle(); 26 const Script& script = Script::Handle();
26 const Class& owner_class = Class::Handle( 27 const Class& owner_class = Class::Handle(
27 Class::New(class_name, script, TokenPosition::kNoSource)); 28 Class::New(class_name, script, TokenPosition::kNoSource));
28 const String& function_name = String::Handle(Symbols::New("callerFunction")); 29 const String& function_name = String::Handle(Symbols::New(thread,
30 "callerFunction"));
29 const Function& function = Function::Handle( 31 const Function& function = Function::Handle(
30 Function::New(function_name, RawFunction::kRegularFunction, 32 Function::New(function_name, RawFunction::kRegularFunction,
31 true, false, false, false, false, owner_class, 33 true, false, false, false, false, owner_class,
32 TokenPosition::kNoSource)); 34 TokenPosition::kNoSource));
33 35
34 const String& target_name = String::Handle(String::New("targetFunction")); 36 const String& target_name = String::Handle(String::New("targetFunction"));
35 const Array& args_descriptor = 37 const Array& args_descriptor =
36 Array::Handle(ArgumentsDescriptor::New(1, Object::null_array())); 38 Array::Handle(ArgumentsDescriptor::New(1, Object::null_array()));
37 const ICData& ic_data = ICData::ZoneHandle(ICData::New(function, 39 const ICData& ic_data = ICData::ZoneHandle(ICData::New(function,
38 target_name, 40 target_name,
(...skipping 17 matching lines...) Expand all
56 CodePatcher::GetInstanceCallAt(return_address, test->code(), &ic_data); 58 CodePatcher::GetInstanceCallAt(return_address, test->code(), &ic_data);
57 EXPECT_STREQ("targetFunction", 59 EXPECT_STREQ("targetFunction",
58 String::Handle(ic_data.target_name()).ToCString()); 60 String::Handle(ic_data.target_name()).ToCString());
59 EXPECT_EQ(1, ic_data.NumArgsTested()); 61 EXPECT_EQ(1, ic_data.NumArgsTested());
60 EXPECT_EQ(0, ic_data.NumberOfChecks()); 62 EXPECT_EQ(0, ic_data.NumberOfChecks());
61 } 63 }
62 64
63 } // namespace dart 65 } // namespace dart
64 66
65 #endif // defined TARGET_ARCH_ARM64 67 #endif // defined TARGET_ARCH_ARM64
OLDNEW
« no previous file with comments | « runtime/vm/code_generator_test.cc ('k') | runtime/vm/code_patcher_arm_test.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698