Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(175)

Unified Diff: runtime/vm/scopes_test.cc

Issue 1870343002: - Refactor Symbol allocation to expect a thread parameter. (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: Address review feedback. Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/vm/scanner.cc ('k') | runtime/vm/service_test.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/scopes_test.cc
diff --git a/runtime/vm/scopes_test.cc b/runtime/vm/scopes_test.cc
index 8dac606ca847f11140bbf987e954f0b27bc798c4..807f9f973614ba408cf407031985a6bac3f8d1cd 100644
--- a/runtime/vm/scopes_test.cc
+++ b/runtime/vm/scopes_test.cc
@@ -12,18 +12,18 @@ namespace dart {
TEST_CASE(LocalScope) {
// Allocate a couple of local variables first.
const Type& dynamic_type = Type::ZoneHandle(Type::DynamicType());
- const String& a = String::ZoneHandle(Symbols::New("a"));
+ const String& a = String::ZoneHandle(Symbols::New(thread, "a"));
LocalVariable* var_a =
new LocalVariable(TokenPosition::kNoSource, a, dynamic_type);
LocalVariable* inner_var_a =
new LocalVariable(TokenPosition::kNoSource, a, dynamic_type);
- const String& b = String::ZoneHandle(Symbols::New("b"));
+ const String& b = String::ZoneHandle(Symbols::New(thread, "b"));
LocalVariable* var_b =
new LocalVariable(TokenPosition::kNoSource, b, dynamic_type);
- const String& c = String::ZoneHandle(Symbols::New("c"));
+ const String& c = String::ZoneHandle(Symbols::New(thread, "c"));
LocalVariable* var_c =
new LocalVariable(TokenPosition::kNoSource, c, dynamic_type);
- const String& L = String::ZoneHandle(Symbols::New("L"));
+ const String& L = String::ZoneHandle(Symbols::New(thread, "L"));
SourceLabel* label_L =
new SourceLabel(TokenPosition::kNoSource, L, SourceLabel::kFor);
« no previous file with comments | « runtime/vm/scanner.cc ('k') | runtime/vm/service_test.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698