runtime/vm/dart_api_impl.h - Issue 1870343002: - Refactor Symbol allocation to expect a thread parameter.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/vm/dart_api_impl.h

Issue 1870343002: - Refactor Symbol allocation to expect a thread parameter. (Closed) Base URL: git@github.com:dart-lang/sdk.git@master

Patch Set: Address review feedback. Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: runtime/vm/dart_api_impl.h

diff --git a/runtime/vm/dart_api_impl.h b/runtime/vm/dart_api_impl.h

index 67c025725e9919691da3262a2404a10759ae72f4..f536e0bfb6ecdfbc744f6b4d190484bfdbbab544 100644

--- a/runtime/vm/dart_api_impl.h

+++ b/runtime/vm/dart_api_impl.h

@@ -57,7 +57,7 @@ const char* CanonicalFunction(const char* func);

#define DARTSCOPE(thread) \

Thread* T = (thread); \

CHECK_API_SCOPE(T); \

- TransitionNativeToVM trainsition(T); \

+ TransitionNativeToVM transition(T); \

HANDLESCOPE(T);

« no previous file with comments | « runtime/vm/compiler_test.cc ('k') | runtime/vm/dart_api_impl.cc » ('j') | no next file with comments »