Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(227)

Side by Side Diff: runtime/vm/stub_code_arm_test.cc

Issue 1870343002: - Refactor Symbol allocation to expect a thread parameter. (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: Address review feedback. Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « runtime/vm/stub_code_arm64_test.cc ('k') | runtime/vm/stub_code_ia32_test.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2013, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2013, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 #include "vm/globals.h" 5 #include "vm/globals.h"
6 #if defined(TARGET_ARCH_ARM) 6 #if defined(TARGET_ARCH_ARM)
7 7
8 #include "vm/isolate.h" 8 #include "vm/isolate.h"
9 #include "vm/dart_entry.h" 9 #include "vm/dart_entry.h"
10 #include "vm/native_entry.h" 10 #include "vm/native_entry.h"
11 #include "vm/native_entry_test.h" 11 #include "vm/native_entry_test.h"
12 #include "vm/object.h" 12 #include "vm/object.h"
13 #include "vm/runtime_entry.h" 13 #include "vm/runtime_entry.h"
14 #include "vm/stub_code.h" 14 #include "vm/stub_code.h"
15 #include "vm/symbols.h" 15 #include "vm/symbols.h"
16 #include "vm/unit_test.h" 16 #include "vm/unit_test.h"
17 17
18 #define __ assembler-> 18 #define __ assembler->
19 19
20 namespace dart { 20 namespace dart {
21 21
22 static Function* CreateFunction(const char* name) { 22 static Function* CreateFunction(const char* name) {
23 const String& class_name = String::Handle(Symbols::New("ownerClass")); 23 const String& class_name = String::Handle(Symbols::New(Thread::Current(),
24 "ownerClass"));
24 const Script& script = Script::Handle(); 25 const Script& script = Script::Handle();
25 const Class& owner_class = Class::Handle( 26 const Class& owner_class = Class::Handle(
26 Class::New(class_name, script, TokenPosition::kNoSource)); 27 Class::New(class_name, script, TokenPosition::kNoSource));
27 const Library& lib = Library::Handle(Library::New(class_name)); 28 const Library& lib = Library::Handle(Library::New(class_name));
28 owner_class.set_library(lib); 29 owner_class.set_library(lib);
29 const String& function_name = String::ZoneHandle(Symbols::New(name)); 30 const String& function_name = String::ZoneHandle(
31 Symbols::New(Thread::Current(), name));
30 Function& function = Function::ZoneHandle( 32 Function& function = Function::ZoneHandle(
31 Function::New(function_name, RawFunction::kRegularFunction, 33 Function::New(function_name, RawFunction::kRegularFunction,
32 true, false, false, false, false, owner_class, 34 true, false, false, false, false, owner_class,
33 TokenPosition::kNoSource)); 35 TokenPosition::kNoSource));
34 return &function; 36 return &function;
35 } 37 }
36 38
37 39
38 // Test calls to stub code which calls into the runtime. 40 // Test calls to stub code which calls into the runtime.
39 static void GenerateCallToCallRuntimeStub(Assembler* assembler, 41 static void GenerateCallToCallRuntimeStub(Assembler* assembler,
(...skipping 60 matching lines...) Expand 10 before | Expand all | Expand 10 after
100 *CreateFunction("Test_CallLeafRuntimeStubCode"), &_assembler_)); 102 *CreateFunction("Test_CallLeafRuntimeStubCode"), &_assembler_));
101 const Function& function = RegisterFakeFunction(kName, code); 103 const Function& function = RegisterFakeFunction(kName, code);
102 Smi& result = Smi::Handle(); 104 Smi& result = Smi::Handle();
103 result ^= DartEntry::InvokeFunction(function, Object::empty_array()); 105 result ^= DartEntry::InvokeFunction(function, Object::empty_array());
104 EXPECT_EQ(1, result.Value()); 106 EXPECT_EQ(1, result.Value());
105 } 107 }
106 108
107 } // namespace dart 109 } // namespace dart
108 110
109 #endif // defined TARGET_ARCH_ARM 111 #endif // defined TARGET_ARCH_ARM
OLDNEW
« no previous file with comments | « runtime/vm/stub_code_arm64_test.cc ('k') | runtime/vm/stub_code_ia32_test.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698