Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(261)

Unified Diff: runtime/vm/dart_api_impl.cc

Issue 1870343002: - Refactor Symbol allocation to expect a thread parameter. (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: Address review feedback. Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/vm/dart_api_impl.h ('k') | runtime/vm/dart_api_impl_test.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/dart_api_impl.cc
diff --git a/runtime/vm/dart_api_impl.cc b/runtime/vm/dart_api_impl.cc
index a53b4d41d3e384712edba10f699772a4c6ba63f3..e8c31a9e10f8171cfa4a4e98f9fe64fe1152ff6b 100644
--- a/runtime/vm/dart_api_impl.cc
+++ b/runtime/vm/dart_api_impl.cc
@@ -4618,7 +4618,7 @@ DART_EXPORT Dart_Handle Dart_CreateNativeWrapperClass(Dart_Handle library,
}
CHECK_CALLBACK_STATE(T);
- String& cls_symbol = String::Handle(Z, Symbols::New(cls_name));
+ String& cls_symbol = String::Handle(Z, Symbols::New(T, cls_name));
const Class& cls = Class::Handle(Z,
Class::NewNativeWrapper(lib, cls_symbol, field_count));
if (cls.IsNull()) {
@@ -5472,7 +5472,7 @@ DART_EXPORT Dart_Handle Dart_LibraryImportLibrary(Dart_Handle library,
CHECK_CALLBACK_STATE(T);
CHECK_COMPILATION_ALLOWED(I);
- const String& prefix_symbol = String::Handle(Z, Symbols::New(prefix_vm));
+ const String& prefix_symbol = String::Handle(Z, Symbols::New(T, prefix_vm));
const Namespace& import_ns = Namespace::Handle(Z,
Namespace::New(import_vm, Object::null_array(), Object::null_array()));
if (prefix_vm.Length() == 0) {
« no previous file with comments | « runtime/vm/dart_api_impl.h ('k') | runtime/vm/dart_api_impl_test.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698