runtime/vm/compiler.cc - Issue 1870343002: - Refactor Symbol allocation to expect a thread parameter.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/vm/compiler.cc

Issue 1870343002: - Refactor Symbol allocation to expect a thread parameter. (Closed) Base URL: git@github.com:dart-lang/sdk.git@master

Patch Set: Address review feedback. Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: runtime/vm/compiler.cc

diff --git a/runtime/vm/compiler.cc b/runtime/vm/compiler.cc

index 9f3c02fe43aad0407ae535f5999b0f6d4bae07d4..9f4068b03ec4098f9587c1e722ac71763081c467 100644

--- a/runtime/vm/compiler.cc

+++ b/runtime/vm/compiler.cc

@@ -1501,7 +1501,7 @@ RawObject* Compiler::ExecuteOnce(SequenceNode* fragment) {

// Function fits the bill.

const char* kEvalConst = "eval_const";

const Function& func = Function::ZoneHandle(Function::New(

- String::Handle(Symbols::New(kEvalConst)),

+ String::Handle(Symbols::New(thread, kEvalConst)),

RawFunction::kRegularFunction,

true, // static function

false, // not const function

« no previous file with comments | « runtime/vm/code_patcher_x64_test.cc ('k') | runtime/vm/compiler_test.cc » ('j') | no next file with comments »